Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added diagnostics and quickfix for a managed bean class of generic type #225

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Added diagnostics and quickfix for a managed bean class of generic type #225

merged 2 commits into from
Dec 2, 2021

Conversation

KidoVin01
Copy link
Contributor

Fixes #210

himanshuc71
himanshuc71 reviewed Nov 30, 2021
View reviewed changes
Copy link
Contributor

@himanshuc71 himanshuc71 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good, just suggesting minor changes for readability. Did you add a quick fix or just the diagnostic? I see tests for code action but not implementation in this PR.

...core/src/main/java/org/eclipse/lsp4jakarta/jdt/core/cdi/ManagedBeanDiagnosticsCollector.java Outdated Show resolved Hide resolved
...core/src/main/java/org/eclipse/lsp4jakarta/jdt/core/cdi/ManagedBeanDiagnosticsCollector.java Outdated Show resolved Hide resolved
...ipse.lsp4jakarta.jdt.test/src/main/java/org/eclipse/lsp4jakarta/jdt/cdi/ManagedBeanTest.java Show resolved Hide resolved
@KidoVin01
Copy link
Contributor Author

Logic looks good, just suggesting minor changes for readability. Did you add a quick fix or just the diagnostic? I see tests for code action but not implementation in this PR.

The code action already exists, so I just reused it.

@KidoVin01 KidoVin01 force-pushed the main branch 2 times, most recently from d06b37a to d675226 Compare December 1, 2021 03:16
@kathrynkodama kathrynkodama merged commit b867f89 into eclipse-lsp4jakarta:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himanshuc71 himanshuc71 himanshuc71 left review comments

@kathrynkodama kathrynkodama kathrynkodama approved these changes

@ananya2801 ananya2801 Awaiting requested review from ananya2801

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency Injection: Diagnostics for bean class of generic or parameterized type
3 participants
@KidoVin01 @kathrynkodama @himanshuc71