Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the JakartaProjectLabelProvider return finer grained labels? #512

Open
mrglavas opened this issue Jan 23, 2024 · 0 comments
Open

Comments

@mrglavas
Copy link

mrglavas commented Jan 23, 2024

This came up during a code review of Liberty Tools for IntelliJ which included a ported version of JakartaProjectLabelProvider. See discussion here: OpenLiberty/liberty-tools-intellij#614 (comment).

Currently JakartaProjectLabelProvider is determining that a project is a Jakarta project by merely checking for the availability of jakarta.ws.rs.GET on the classpath. Application servers such as Open Liberty are composable and users may specify configuration (e.g. server.xml features for a Liberty application) that only loads/utilizes a subset of Jakarta EE functionality like JPA or selects a specific version of Jakarta EE (e.g. 10). We thought this might be a good case for defining finer grained labels for each of the separately loadable modules and versions of Jakarta EE. A similar argument could also be made for the Microprofile label provider from LSP4MP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant