Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Dependency Injection diagnostic: Injectable fields cannot be final #195

Closed
himanshuc71 opened this issue Oct 26, 2021 · 1 comment
Closed

Add tests for Dependency Injection diagnostic: Injectable fields cannot be final #195

himanshuc71 opened this issue Oct 26, 2021 · 1 comment
Assignees
@himanshuc71
Labels
diagnostic Diagnostic item

Comments

@himanshuc71
Copy link
Contributor

Test the implementation for #167.

Based on #153.
@himanshuc71
Copy link
Contributor Author

Please assign this to me, @kathrynkodama, thank you

@kathrynkodama kathrynkodama added the diagnostic Diagnostic item label Oct 27, 2021
@himanshuc71 himanshuc71 mentioned this issue Nov 22, 2021
Merged
himanshuc71 added a commit to himanshuc71/lsp4jakarta that referenced this issue Nov 22, 2021
@himanshuc71
Added tests for DI quickFixes
a827c90 
Issues: eclipse#195, eclipse#221
himanshuc71 added a commit to himanshuc71/lsp4jakarta that referenced this issue Nov 23, 2021
@himanshuc71
Added tests for DI quickFixes
e2fee06 
Issues: eclipse#195, eclipse#221
kathrynkodama pushed a commit that referenced this issue Nov 24, 2021
@himanshuc71
Integration tests for Dependency Injection (#222)
8a04ae4 
* Diagnostics/QuickFixes for static, generic method with @Inject

* Integration tests for DependencyInjection

Inject field non final diagnostic
Inject method non final, non static, non abstract, non generic

* Added tests for DI quickFixes
Issues: #195, #221

* Fixed small bug in test

* small formatting changes
tiganov pushed a commit to tiganov/lsp4jakarta that referenced this issue Dec 1, 2021
@himanshuc71 @tiganov
Integration tests for Dependency Injection (eclipse#222)
4413a49 
* Diagnostics/QuickFixes for static, generic method with @Inject

* Integration tests for DependencyInjection

Inject field non final diagnostic
Inject method non final, non static, non abstract, non generic

* Added tests for DI quickFixes
Issues: eclipse#195, eclipse#221

* Fixed small bug in test

* small formatting changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@himanshuc71 himanshuc71

Labels
diagnostic Diagnostic item
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kathrynkodama @himanshuc71