Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depedency Injection: Diagnostic for final, abstract, static and generic @Inject methods #168

Closed
Tracked by #16
KidoVin01 opened this issue Sep 28, 2021 · 3 comments · Fixed by #202
Closed
Tracked by #16
Assignees
Labels
diagnostic Diagnostic item

Comments

@KidoVin01
Copy link
Contributor

KidoVin01 commented Sep 28, 2021

Depedency Injection Spec

An initializer method is a default-access, public, protected or private, non-abstract, non-static, non-generic method of a bean class or of any other classes supporting injection.

Diagnostics

  • Identify @Inject methods
  • If method is final, abstract, static and generic, deliver diagnostic error

Quick Fix:

  • Remove the modifiers
  • Remove the annotation

Related to #153

@kathrynkodama kathrynkodama added the diagnostic Diagnostic item label Sep 29, 2021
@kathrynkodama
Copy link
Contributor

Similar to #167, clarify the spec and if this is for @Inject

@KidoVin01 KidoVin01 changed the title Add support for final and abstract methods Depedency Injection: Diagnostic for final and abstract @Inject methods Oct 1, 2021
@himanshuc71
Copy link
Contributor

working on it

@KidoVin01
Copy link
Contributor Author

I have edited the title to now reflect having to provide diagnostics for static and generic methods based on this spec

An initializer method is a default-access, public, protected or private, non-abstract, non-static, non-generic method of a bean class or of any other classes supporting injection.

@KidoVin01 KidoVin01 changed the title Depedency Injection: Diagnostic for final and abstract @Inject methods Depedency Injection: Diagnostic for final, abstract, static and generic @Inject methods Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagnostic Diagnostic item
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants