Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifying Plot (XY) data providers design. #127

Open
MatthewKhouzam opened this issue Jul 23, 2024 · 3 comments
Open

Unifying Plot (XY) data providers design. #127

MatthewKhouzam opened this issue Jul 23, 2024 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@MatthewKhouzam
Copy link
Contributor

Right now we have several XY data providers:

image

It would be interesting to investigate the data providers and see if there's a way to have a unified code path. In doing so, it could lead to a universal customized xy tree data provider. This in turn would allow for that dataprovider to be properly customizable.

Warning: this could be API breaking, I think we need to discuss it from an Architecture level.

One thing to ask here: what would the ideal XY plot have as parameters to customize? I would love insights from more UXy people as this pertains to DX (Developer experience). @ebugden.

@MatthewKhouzam MatthewKhouzam added the help wanted Extra attention is needed label Jul 23, 2024
@ebugden
Copy link

ebugden commented Jul 24, 2024

@MatthewKhouzam Before weighing in, I'd need a better understanding of the underlying user problem that this solution proposes to address. Is the problem that XY charts cannot be "customized" at the moment? Could you clarify what "customization" refers to?

@MatthewKhouzam
Copy link
Contributor Author

The XY chart can be customized by code. We noticed students getting paralyzed unable to pick which data provider to extend.

Customization ideas:

  • title
  • axes (units, formating)
  • is the data cumulative or absolute
  • series palette
  • I need more ideas

@ebugden
Copy link

ebugden commented Jul 25, 2024

I'm still fuzzy on what's going on. Is the underlying problem is that Trace Compass contributors and extenders who want to add a new XY view are unsure about which data provider to extend? And the proposed solution is to refactor to have one general XY data provider whose code can be more easily adapted to different graphical encodings e.g. different axis units/titles?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants