Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[378] Remove code now fixed in GMF #379

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lredor
Copy link
Contributor

@lredor lredor commented Apr 25, 2024

This commit removes the code duplicated from GMF as the bug is now directly fixed in GMF (through issue
eclipse-gmf-runtime/gmf-runtime#63).

Bug: #378

@lredor
Copy link
Contributor Author

lredor commented Apr 25, 2024

This PR needs the integration of a GMF version containing the fix of eclipse-gmf-runtime/gmf-runtime#63.
Steps to validate: The tests from org.eclipse.sirius.tests.swtbot.MoveAllShapesWithArrowKeysTest should be OK.

@lredor lredor force-pushed the bug/lre/359-moveFromKeyboard branch 2 times, most recently from 6f99363 to 3ed7653 Compare April 26, 2024 16:00
Base automatically changed from bug/lre/359-moveFromKeyboard to master April 29, 2024 14:58
This commit removes the code duplicated from GMF as the bug is now
directly fixed in GMF (through issue
eclipse-gmf-runtime/gmf-runtime#63).

Bug: #378
@lredor lredor linked an issue Jun 27, 2024 that may be closed by this pull request
@lredor lredor force-pushed the lre/bug/378-removeCodeFixedInGMF branch from abd5e7a to 2180bb2 Compare June 27, 2024 07:27
@lredor
Copy link
Contributor Author

lredor commented Jun 27, 2024

The last "force-push" is a rebase on master branch. Nevertheless, the PR needs that Sirius uses a new version of GMF to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean code done for #359 by using new version of GMF
1 participant