Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean code done for #359 by using new version of GMF/GEF #376

Open
lredor opened this issue Apr 25, 2024 · 0 comments · May be fixed by #377
Open

Clean code done for #359 by using new version of GMF/GEF #376

lredor opened this issue Apr 25, 2024 · 0 comments · May be fixed by #377
Labels
component: diagrams type: enhancement Making an existing feature better
Milestone
Next major

Comments

@lredor
Copy link
Contributor

lredor commented Apr 25, 2024

Some code has been temporarily duplicated from GEF. This code will be APIs in GEF 3.20 version. The idea of this issue is to clean the code when Sirius will use a new version of GMF using GEF 3.20 (see GMF bug eclipse-gmf-runtime/gmf-runtime#62).
@lredor lredor added this to the v8.0.0 milestone Apr 25, 2024
lredor added a commit that referenced this issue Apr 25, 2024
@lredor
[376] Remove code now accessible as APIs in GEF
868617a 
This commit removes the code duplicated from GEF as it is now available
as API in GEF (through issue
eclipse-gef/gef-classic#426).

Bug: #376
@lredor lredor linked a pull request Apr 25, 2024 that will close this issue
Open
@lredor lredor added type: enhancement Making an existing feature better component: diagrams labels Apr 25, 2024
@lredor lredor mentioned this issue Apr 25, 2024
Closed
@lredor lredor linked a pull request Jun 27, 2024 that will close this issue
[376] Remove code now accessible as APIs in GEF #377
Open
lredor added a commit that referenced this issue Jun 27, 2024
@lredor
[376] Remove code now accessible as APIs in GEF
dff3f2b 
This commit removes the code duplicated from GEF as it is now available
as API in GEF (through issue
eclipse-gef/gef-classic#426).

Bug: #376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: diagrams type: enhancement Making an existing feature better
Projects
None yet
Milestone
Next major
Development

Successfully merging a pull request may close this issue.

[376] Remove code now accessible as APIs in GEF eclipse-sirius/sirius-desktop
1 participant
@lredor