Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for memory leak in GMF Runtime up to 1.16.3 #338

Open
pcdavid opened this issue Mar 29, 2024 · 0 comments · May be fixed by #339
Open

Workaround for memory leak in GMF Runtime up to 1.16.3 #338

pcdavid opened this issue Mar 29, 2024 · 0 comments · May be fixed by #339
Labels
component: diagrams type: bug Something isn't working
Milestone
v7.4.5

Comments

@pcdavid
Copy link
Member

pcdavid commented Mar 29, 2024

See eclipse-gmf-runtime/gmf-runtime#53, which fixes a memory leak in GMF Runtime's ConnectionEditPart. The fix is merged, but will not be available until a new 1.16.4 release is done (for which I have no fixed date yet).
Until then, since all our edge edit parts in Sirius inherit from the same AbstractDiagramEdgeEditPart, we can include a workaround on our side.

The missing removeNotationalListeners() which we will add on our side seems safe to be called mulitple times, so while it'd be better to remove our workaround once we move to GMF Runtime 1.16.4, it should not cause any actual issue if we don't.
@pcdavid pcdavid added this to the v7.4.1 milestone Mar 29, 2024
@pcdavid pcdavid added type: bug Something isn't working component: diagrams labels Mar 29, 2024
pcdavid added a commit that referenced this issue Mar 29, 2024
@pcdavid
[338] Workaround memory leak in GMF Runtime
3178f9b 
Bug: #338
Signed-off-by: Pierre-Charles David <[email protected]>
@pcdavid pcdavid linked a pull request Mar 29, 2024 that will close this issue
Open
@pcdavid pcdavid linked a pull request Mar 29, 2024 that will close this issue
[338] Workaround memory leak in GMF Runtime #339
Open
@pcdavid pcdavid modified the milestones: v7.4.1, v7.4.2 Mar 29, 2024
@pcdavid pcdavid modified the milestones: v7.4.2, v7.4.3 Jun 20, 2024
pcdavid added a commit that referenced this issue Jun 27, 2024
@pcdavid
[338] Workaround memory leak in GMF Runtime
9766688 
Bug: #338
Signed-off-by: Pierre-Charles David <[email protected]>
@pcdavid pcdavid modified the milestones: v7.4.3, v7.4.4 Aug 30, 2024
@pcdavid pcdavid modified the milestones: v7.4.4, v7.4.5 Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: diagrams type: bug Something isn't working
Projects
None yet
Milestone
v7.4.5
Development

Successfully merging a pull request may close this issue.

[338] Workaround memory leak in GMF Runtime eclipse-sirius/sirius-desktop
1 participant
@pcdavid