Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-5130 sh:oneOrMorePath, sh:zeroOrMorePath, sh:zeroOrOnePath #5131

Merged
merged 7 commits into from
Nov 21, 2024

Conversation

hmottestad
Copy link
Contributor

GitHub issue resolved: #5130

Briefly describe the changes proposed in this PR:


PR Author Checklist (see the contributor guidelines for more details):

  • my pull request is self-contained
  • I've added tests for the changes I made
  • I've applied code formatting (you can use mvn process-resources to format from the command line)
  • I've squashed my commits where necessary
  • every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

@hmottestad hmottestad force-pushed the GH-5130_shacl_oneOrMorePath branch from e08f9aa to 347a8c5 Compare September 24, 2024 07:27
@hmottestad hmottestad changed the title GH-5130 sh:oneOrMorePath GH-5130 sh:oneOrMorePath, sh:zeroOrMorePath, sh:zeroOrOnePath Sep 24, 2024
@hmottestad
Copy link
Contributor Author

Try to make the query for oneOrMore be split into one and two or more by having the first path in the two-or-more be with + instead of *.

Also remember that the path for one should be with full variables.

@hmottestad hmottestad force-pushed the GH-5130_shacl_oneOrMorePath branch from 0d415c6 to e5c13d4 Compare October 27, 2024 10:37
@hmottestad hmottestad force-pushed the GH-5130_shacl_oneOrMorePath branch 4 times, most recently from 2b1c348 to 8943323 Compare November 21, 2024 10:53
@hmottestad hmottestad force-pushed the GH-5130_shacl_oneOrMorePath branch from 8943323 to de41bf7 Compare November 21, 2024 11:03
@hmottestad hmottestad marked this pull request as ready for review November 21, 2024 12:19
@hmottestad hmottestad force-pushed the GH-5130_shacl_oneOrMorePath branch from d70ee8d to 8ced4d5 Compare November 21, 2024 12:50
@hmottestad hmottestad force-pushed the GH-5130_shacl_oneOrMorePath branch from 8ced4d5 to fa55005 Compare November 21, 2024 13:01
@hmottestad hmottestad merged commit 3d80cdc into develop Nov 21, 2024
9 checks passed
@hmottestad hmottestad deleted the GH-5130_shacl_oneOrMorePath branch November 21, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant