java.io.File.toURL() is deprecated and marked for removal. Replace it

with file.toURI().toURL(), where toURL() is called on a java.net.URI
instance, which is not deprecated and handles encoding correctly.

Author: elsazac

resources/bundles/org.eclipse.core.resources/src/org/eclipse/core/internal/resources/PlatformURLResourceConnection.java

@@ -104,7 +104,7 @@ public static void startup(IPath root) {
 		if (rootURL != null)
 			return;
 		try {
-			rootURL = root.toFile().toURL();
+			rootURL = root.toFile().toURI().toURL();
 		} catch (MalformedURLException e) {
 			// should never happen but if it does, the resource URL cannot be supported.
 			return;

update/org.eclipse.update.configurator/src/org/eclipse/update/internal/configurator/PlatformConfiguration.java

@@ -122,7 +122,7 @@ private PlatformConfiguration(Location platformConfigLocation) throws CoreExcept
 		// Retrieve install location with respect to given url if possible
 		try {
 			if (url != null && url.getProtocol().equals("file") && url.getPath().endsWith("configuration/org.eclipse.update/platform.xml")) {
-				installLocation = IPath.fromOSString(url.getPath()).removeLastSegments(3).toFile().toURL();
+				installLocation = IPath.fromOSString(url.getPath()).removeLastSegments(3).toFile().toURI().toURL();
 			}
 		} catch (Exception e) {
 			//
@@ -853,7 +853,7 @@ private Configuration loadConfig(URL url, URL installLocation) throws Exception
 						if (workingDir != null && workingDir.exists()) {
 							File[] backups = workingDir.listFiles((FileFilter) pathname -> pathname.isFile() && pathname.getName().endsWith(".xml"));
 							if (backups != null && backups.length > 0) {
-								URL backupUrl = backups[backups.length - 1].toURL();
+								URL backupUrl = backups[backups.length - 1].toURI().toURL();
 								config = parser.parse(backupUrl, installLocation);
 							}
 						}
@@ -914,7 +914,7 @@ public static URL resolvePlatformURL(URL url, URL base_path_Location) throws IOE
 			if (base_path_Location == null) {
 				url = FileLocator.toFileURL(url);
 				File f = new File(url.getFile());
-				url = f.toURL();
+				url = f.toURI().toURL();
 			} else {
 				final String BASE = "platform:/base/";
 				final String CONFIG = "platform:/config/";

update/org.eclipse.update.configurator/src/org/eclipse/update/internal/configurator/SiteEntry.java

@@ -71,7 +71,7 @@ public SiteEntry(URL url, ISitePolicy policy) {
 		if (url.getProtocol().equals("file")) { //$NON-NLS-1$
 			try {
 				// TODO remove this when platform fixes local file url's
-				this.url = new File(url.getFile()).toURL(); 
+				this.url = new File(url.getFile()).toURI().toURL(); 
 			} catch (MalformedURLException e1) {
 				this.url = url;
 			}
@@ -278,7 +278,7 @@ private void detectFeatures() {
 					if (featureXML.lastModified() <= featuresChangeStamp &&
 						dir.lastModified() <= featuresChangeStamp)
 						continue;
-					URL featureURL = featureXML.toURL();
+					URL featureURL = featureXML.toURI().toURL();
 					FeatureEntry featureEntry = featureParser.parse(featureURL);
 					if (featureEntry != null)
 						addFeatureEntry(featureEntry);

update/org.eclipse.update.configurator/src/org/eclipse/update/internal/configurator/Utils.java

@@ -411,7 +411,7 @@ public static URL makeAbsolute(URL base, URL relativeLocation) {
 		try {
 			IPath absolutePath = IPath.fromOSString(base.getPath()).append(relativeLocation.getPath());
 			// File.toURL() is the best way to create a file: URL
-			return absolutePath.toFile().toURL();
+			return absolutePath.toFile().toURI().toURL();
 		} catch (MalformedURLException e) {
 			// cannot happen since we are building from two existing valid URLs
 			Utils.log(e.getLocalizedMessage());
@@ -488,7 +488,7 @@ public static String canonicalizeURL(String url) {
 				char[] chars = path.toCharArray();
 				chars[0] = Character.toLowerCase(chars[0]);
 				path = new String(chars);
-				return new File(path).toURL().toExternalForm();
+				return new File(path).toURI().toURL().toExternalForm();
 			}
 		} catch (MalformedURLException e) {
 			// default to original url