Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Find/Replace] changed search string is ignored by search dialog #2322

Closed
Tracked by #2021
iloveeclipse opened this issue Sep 24, 2024 · 3 comments · Fixed by #2327
Closed
Tracked by #2021

[Find/Replace] changed search string is ignored by search dialog #2322

iloveeclipse opened this issue Sep 24, 2024 · 3 comments · Fixed by #2327
Labels
bug Something isn't working regression

Comments

@iloveeclipse
Copy link
Member

I believe this is a regression in the recent code related to Find/Replace.

I'm using "old" Find/Replace dialog, latest SDK build I20240923-1800.

  1. Open FindReplaceDialog.java in the IDE
  2. Select findReplaceLogic at line 83 and trigger Ctrl+F to open find/replace dialog
  3. Click once on Find => should jump to line 107 and highlight findReplaceLogic string (OK).
  4. In the find/replace dialog, type "." after findReplaceLogic search text and click on "Find"
  5. The dialog continues to search with the old search string and selects next findReplaceLogic occurrence on line 108.
  6. Change search direction to "backward" and click "Find" two times => we are at line 83 again, where no match for findReplaceLogic. should be found!

image
@iloveeclipse iloveeclipse added bug Something isn't working regression labels Sep 24, 2024
@iloveeclipse
Copy link
Member Author

@Wittmaxi, @HeikoKlare : FYI.

I didn't investigated if this related to the overlay work, if yes, probably should be added to #2021

@HeikoKlare
Copy link
Contributor

Thank you for the detailed reproduction description. I expect this to be a regression of #2209. I will try to have a look as soon as possible.

@HeikoKlare HeikoKlare mentioned this issue Sep 24, 2024
Open
72 tasks
@HeikoKlare
Copy link
Contributor

The issue is not reproducible in MacOS. Since the search string in the FindReplaceLogic is updated after changing the text field (via reacting to the modification event), it might be related to event handling in GTK, i.e., a Linux-specific issue. I will further investigate once I have access to a Linux system again (probably at the end of the week). I have added this issue to the umbrella ticket with high prio.

HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Sep 25, 2024
@HeikoKlare
Find/replace dialog: properly update search string eclipse-platform#2322
c3be003 


The find/replace dialog does currently not properly update its search
string. When changing the search string and pressing return to execute a
search, the previous search string is taken. The reason is an existing
workaround for event handling of Combos in GTK.

This change ensures that the search and replace input strings are
properly updated upon every text modification in the according widgets.

Fixes eclipse-platform#2322
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Sep 25, 2024
@HeikoKlare
Find/replace dialog: properly update search string eclipse-platform#2322
21a69c8 


The find/replace dialog does currently not properly update its search
string. When changing the search string and pressing return to execute a
search, the previous search string is taken. The reason is an existing
workaround for event handling of Combos in GTK.

This change ensures that the search and replace input strings are
properly updated upon every text modification in the according widgets.

Fixes eclipse-platform#2322
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Sep 25, 2024
@HeikoKlare
Find/replace dialog: properly update search string eclipse-platform#2322
4a3149a 


The find/replace dialog does currently not properly update its search
string. When changing the search string and pressing return to execute a
search, the previous search string is taken. The reason is an existing
workaround for event handling of Combos in GTK.

This change ensures that the search and replace input strings are
properly updated upon every text modification in the according widgets.

Fixes eclipse-platform#2322
@HeikoKlare HeikoKlare mentioned this issue Sep 25, 2024
Merged
HeikoKlare added a commit that referenced this issue Sep 26, 2024
@HeikoKlare
Find/replace dialog: properly update search string #2322
5aee5c5 
The find/replace dialog does currently not properly update its search
string. When changing the search string and pressing return to execute a
search, the previous search string is taken. The reason is an existing
workaround for event handling of Combos in GTK.

This change ensures that the search and replace input strings are
properly updated upon every text modification in the according widgets.

Fixes #2322
praveen-skp pushed a commit to praveen-skp/eclipse.platform.ui that referenced this issue Oct 14, 2024
@HeikoKlare @praveen-skp
Find/replace dialog: properly update search string eclipse-platform#2322
493f3ed 


The find/replace dialog does currently not properly update its search
string. When changing the search string and pressing return to execute a
search, the previous search string is taken. The reason is an existing
workaround for event handling of Combos in GTK.

This change ensures that the search and replace input strings are
properly updated upon every text modification in the according widgets.

Fixes eclipse-platform#2322
lathapatil pushed a commit to lathapatil/eclipse.platform.ui that referenced this issue Oct 21, 2024
@HeikoKlare @lathapatil
Find/replace dialog: properly update search string eclipse-platform#2322
3256a7b 


The find/replace dialog does currently not properly update its search
string. When changing the search string and pressing return to execute a
search, the previous search string is taken. The reason is an existing
workaround for event handling of Combos in GTK.

This change ensures that the search and replace input strings are
properly updated upon every text modification in the according widgets.

Fixes eclipse-platform#2322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Find/replace dialog: properly update search string #2322 HeikoKlare/eclipse.platform.ui
2 participants
@HeikoKlare @iloveeclipse