fix CodeMiningLineHeaderAnnotation#getMultilineHeight

tobias-melcher · tobias-melcher · commit ac4f037524c0 · 2025-02-10T17:34:48.000+01:00
it should never return 0. Fix race condition when code minings are not yet available. #2786
diff --git a/bundles/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/codemining/CodeMiningLineHeaderAnnotation.java b/bundles/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/codemining/CodeMiningLineHeaderAnnotation.java
@@ -121,6 +121,9 @@ private int getMultilineHeight(GC gc) {
 			}
 			ignoreFirstLine= true;
 		}
+		if (sumLineHeight == 0) {
+			return super.getHeight();
+		}
 		if (gc != null) {
 			return sumLineHeight;
 		} else {

Original file line number	Diff line number	Diff line change
`@@ -121,6 +121,9 @@ private int getMultilineHeight(GC gc) {`
`121`	`121`	`}`
`122`	`122`	`ignoreFirstLine= true;`
`123`	`123`	`}`
	`124`	`+ if (sumLineHeight == 0) {`
	`125`	`+ return super.getHeight();`
	`126`	`+ }`
`124`	`127`	`if (gc != null) {`
`125`	`128`	`return sumLineHeight;`
`126`	`129`	`} else {`