Skip to content

Dynamize Image constructors with Rectangle #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks done
akoch-yatta opened this issue Jan 21, 2025 · 0 comments · May be fixed by eclipse-platform/eclipse.platform.ui#2953 or eclipse-platform/eclipse.platform.swt#2088
Open
2 tasks done
Assignees
Labels
Enhancement A Request for an Enhancement of an Existing Feature HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Milestone

Comments

@akoch-yatta
Copy link

akoch-yatta commented Jan 21, 2025

The Image constructor with Rectangle looks like a convenience constructor to the constructor with width and height -> x and y of the passed Rectangle is never used anywheren. All existing calls to this constructor (in the platform repo) should be replaced by using a dynamic image provider. Afterwards the constructor should be deprecated

Tasks:

  • Replace all calls to the Image constructor with Rectangle
  • Deprecate the constructor
@akoch-yatta akoch-yatta added Enhancement A Request for an Enhancement of an Existing Feature HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT labels Jan 21, 2025
@akoch-yatta akoch-yatta added this to the 4.36 M1 milestone Jan 21, 2025
@akoch-yatta akoch-yatta moved this to 🔖 Ready: Atomic in HiDPI Jan 21, 2025
@HeikoKlare HeikoKlare modified the milestones: 4.36 M1, 4.36 M2 Feb 24, 2025
@fedejeanne fedejeanne modified the milestones: 4.36 M2, 4.36 M3 Apr 16, 2025
@ShahzaibIbrahim ShahzaibIbrahim self-assigned this May 2, 2025
@ShahzaibIbrahim ShahzaibIbrahim moved this from 🔖 Ready: Atomic to 🏗 In Work: Short in HiDPI May 2, 2025
@ShahzaibIbrahim ShahzaibIbrahim moved this from 🏗 In Work: Short to 👀 In Review in HiDPI May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A Request for an Enhancement of an Existing Feature HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Projects
Status: 👀 In Review
4 participants