[GTK] Remove more *InPixels method

They are not needed at all, double some calls (like checkWidget()), and
overall complicate debugging and understanding the codebase.
Continuation of
#2100

Author: akurtakov

bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Canvas.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2000, 2018 IBM Corporation and others.
+ * Copyright (c) 2000, 2025 IBM Corporation and others.
  *
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License 2.0
@@ -317,12 +317,6 @@ public void scroll (int destX, int destY, int x, int y, int width, int height, b
 	 * as to why it's unneeded is left as a TODO. See bug 546274.
 	 */
 	if (GTK.GTK4) return;
-	Point destination = new Point (destX, destY);
-	Rectangle srcRect = new Rectangle (x, y, width, height);
-	scrollInPixels(destination.x, destination.y, srcRect.x, srcRect.y, srcRect.width, srcRect.height, all);
-}
-
-void scrollInPixels (int destX, int destY, int x, int y, int width, int height, boolean all) {
 	if ((style & SWT.MIRRORED) != 0) {
 		int clientWidth = getClientWidth ();
 		x = clientWidth - width - x;

bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Caret.java

@@ -141,11 +141,6 @@ private void drawInCellEditor(long window) {
  * </ul>
  */
 public Rectangle getBounds () {
-	checkWidget();
-	return getBoundsInPixels();
-}
-
-Rectangle getBoundsInPixels () {
 	checkWidget();
 	if (image != null) {
 		Rectangle rect = image.getBoundsInPixels ();
@@ -201,11 +196,6 @@ public Image getImage () {
  * </ul>
  */
 public Point getLocation () {
-	checkWidget();
-	return getLocationInPixels();
-}
-
-Point getLocationInPixels () {
 	checkWidget();
 	return new Point (x, y);
 }
@@ -236,11 +226,6 @@ public Canvas getParent () {
  * </ul>
  */
 public Point getSize () {
-	checkWidget();
-	return getSizeInPixels();
-}
-
-Point getSizeInPixels () {
 	checkWidget();
 	if (image != null) {
 		Rectangle rect = image.getBoundsInPixels ();
@@ -348,11 +333,6 @@ void releaseWidget () {
  * </ul>
  */
 public void setBounds (int x, int y, int width, int height) {
-	checkWidget();
-	setBounds (new Rectangle (x, y, width, height));
-}
-
-void setBoundsInPixels (int x, int y, int width, int height) {
 	checkWidget();
 	if (this.x == x && this.y == y && this.width == width && this.height == height) return;
 	boolean isFocus = isFocusCaret ();
@@ -377,14 +357,9 @@ void setBoundsInPixels (int x, int y, int width, int height) {
  * </ul>
  */
 public void setBounds (Rectangle rect) {
-	checkWidget();
-	setBoundsInPixels(rect);
-}
-
-void setBoundsInPixels (Rectangle rect) {
 	checkWidget();
 	if (rect == null) error (SWT.ERROR_NULL_ARGUMENT);
-	setBoundsInPixels (rect.x, rect.y, rect.width, rect.height);
+	setBounds (rect.x, rect.y, rect.width, rect.height);
 }
 
 void setFocus () {
@@ -457,12 +432,7 @@ public void setImage (Image image) {
  */
 public void setLocation (int x, int y) {
 	checkWidget();
-	setLocation (new Point (x, y));
-}
-
-void setLocationInPixels (int x, int y) {
-	checkWidget();
-	setBoundsInPixels (x, y, width, height);
+	setBounds (x, y, width, height);
 }
 
 /**
@@ -478,14 +448,9 @@ void setLocationInPixels (int x, int y) {
  * </ul>
  */
 public void setLocation (Point location) {
-	checkWidget();
-	setLocationInPixels (location);
-}
-
-void setLocationInPixels (Point location) {
 	checkWidget();
 	if (location == null) error (SWT.ERROR_NULL_ARGUMENT);
-	setLocationInPixels (location.x, location.y);
+	setLocation (location.x, location.y);
 }
 
 /**
@@ -501,12 +466,7 @@ void setLocationInPixels (Point location) {
  */
 public void setSize (int width, int height) {
 	checkWidget();
-	setSize (new Point (width,height));
-}
-
-void setSizeInPixels (int width, int height) {
-	checkWidget();
-	setBoundsInPixels (x, y, width, height);
+	setBounds (x, y, width, height);
 }
 
 /**
@@ -523,14 +483,9 @@ void setSizeInPixels (int width, int height) {
  * </ul>
  */
 public void setSize (Point size) {
-	checkWidget();
-	setSizeInPixels(size);
-}
-
-void setSizeInPixels (Point size) {
 	checkWidget();
 	if (size == null) error (SWT.ERROR_NULL_ARGUMENT);
-	setSizeInPixels (size.x, size.y);
+	setSize (size.x, size.y);
 }
 
 /**

bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Combo.java

@@ -1080,12 +1080,6 @@ long eventSurface () {
  * @since 3.8
  */
 public Point getCaretLocation () {
-	checkWidget ();
-	return getCaretLocationInPixels();
-}
-
-
-Point getCaretLocationInPixels () {
 	checkWidget ();
 	if ((style & SWT.READ_ONLY) != 0) {
 		return new Point (0, 0);
@@ -1389,12 +1383,6 @@ String getText (int start, int stop) {
  * </ul>
  */
 public int getTextHeight () {
-	checkWidget();
-	return getTextHeightInPixels();
-}
-
-
-int getTextHeightInPixels () {
 	checkWidget();
 	GtkRequisition requisition = new GtkRequisition ();
 	gtk_widget_get_preferred_size (handle, requisition);
@@ -2275,7 +2263,7 @@ void setBackgroundGdkRGBA (long context, long handle, GdkRGBA rgba) {
 @Override
 int setBounds (int x, int y, int width, int height, boolean move, boolean resize) {
 	int newHeight = height;
-	if (resize) newHeight = Math.max (getTextHeightInPixels (), height);
+	if (resize) newHeight = Math.max (getTextHeight (), height);
 	return super.setBounds (x, y, width, newHeight, move, resize);
 }
 

bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Control.java

@@ -6320,14 +6320,14 @@ boolean showMenu (int x, int y, int detail) {
 				if (temp != 0) OS.g_object_unref(temp);
 
 
-				menu.setLocationInPixels(x, y);
+				menu.setLocation(x, y);
 				menu.setVisible(true);
 
 				return true;
 			} else {
 				Rectangle rect = event.getBounds ();
 				if (rect.x != x || rect.y != y) {
-					menu.setLocationInPixels (rect.x, rect.y);
+					menu.setLocation (rect.x, rect.y);
 				}
 				menu.setVisible (true);
 				return true;

bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ExpandBar.java

@@ -483,11 +483,6 @@ void setOrientation (boolean create) {
  * </ul>
  */
 public void setSpacing (int spacing) {
-	checkWidget ();
-	setSpacingInPixels(spacing);
-}
-
-void setSpacingInPixels (int spacing) {
 	checkWidget ();
 	if (spacing < 0) return;
 	if (spacing == this.spacing) return;

bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ExpandItem.java

@@ -232,11 +232,6 @@ public boolean getExpanded() {
  */
 public int getHeaderHeight () {
 	checkWidget ();
-	return getHeaderHeightInPixels ();
-}
-
-int getHeaderHeightInPixels() {
-	checkWidget();
 
 	GtkAllocation allocation = new GtkAllocation();
 	GTK.gtk_widget_get_allocation(GTK.gtk_expander_get_label_widget(handle), allocation);
@@ -506,11 +501,6 @@ void setForegroundRGBA (GdkRGBA rgba) {
  * </ul>
  */
 public void setHeight (int height) {
-	checkWidget ();
-	setHeightInPixels(height);
-}
-
-void setHeightInPixels (int height) {
 	checkWidget ();
 	if (height < 0) return;
 	this.height = height;

bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/List.java

@@ -275,7 +275,7 @@ Point computeSizeInPixels (int wHint, int hHint, boolean changed) {
 	 * based on the number of items in the table
 	 */
 	if (size.y == 0 && hHint == SWT.DEFAULT) {
-		size.y = getItemCount() * getItemHeightInPixels();
+		size.y = getItemCount() * getItemHeight();
 	}
 
 	/*
@@ -536,11 +536,6 @@ public int getItemCount () {
  */
 public int getItemHeight () {
 	checkWidget();
-	return getItemHeightInPixels();
-}
-
-int getItemHeightInPixels() {
-	checkWidget();
 
 	final int BASE_ITEM_PADDING = 1;
 

bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Menu.java

@@ -1198,11 +1198,6 @@ public void setEnabled(boolean enabled) {
  */
 public void setLocation (int x, int y) {
 	checkWidget ();
-	setLocation (new Point (x, y));
-}
-
-void setLocationInPixels (int x, int y) {
-	checkWidget();
 	if ((style & (SWT.BAR | SWT.DROP_DOWN)) != 0) return;
 	this.x = x;
 	this.y = y;
@@ -1235,13 +1230,8 @@ void setLocationInPixels (int x, int y) {
  */
 public void setLocation (Point location) {
 	checkWidget ();
-	setLocationInPixels (location);
-}
-
-void setLocationInPixels (Point location) {
-	checkWidget();
 	if (location == null) error (SWT.ERROR_NULL_ARGUMENT);
-	setLocationInPixels (location.x, location.y);
+	setLocation (location.x, location.y);
 }
 
 /**

bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/ScrollBar.java

@@ -288,11 +288,6 @@ public int getSelection () {
  * </ul>
  */
 public Point getSize () {
-	checkWidget ();
-	return getSizeInPixels ();
-}
-
-Point getSizeInPixels () {
 	checkWidget ();
 	if (handle == 0) return new Point (0,0);
 	GtkRequisition requisition = new GtkRequisition ();

bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/Shell.java

@@ -1295,11 +1295,6 @@ public boolean getMaximized () {
  * @since 3.1
  */
 public Point getMinimumSize () {
-	checkWidget ();
-	return getMinimumSizeInPixels ();
-}
-
-Point getMinimumSizeInPixels () {
 	checkWidget ();
 	int width = Math.max (1, geometry.getMinWidth() + trimWidth ());
 	int height = Math.max (1, geometry.getMinHeight() + trimHeight ());
@@ -1323,12 +1318,6 @@ Point getMinimumSizeInPixels () {
  */
 public Point getMaximumSize () {
 	checkWidget ();
-	return getMaximumSizeInPixels ();
-}
-
-Point getMaximumSizeInPixels () {
-	checkWidget ();
-
 	int width = Math.min (Integer.MAX_VALUE, geometry.getMaxWidth() + trimWidth ());
 	int height = Math.min (Integer.MAX_VALUE, geometry.getMaxHeight() + trimHeight ());
 	return new Point (width, height);
@@ -2661,11 +2650,6 @@ public void setMinimized (boolean minimized) {
  * @since 3.1
  */
 public void setMinimumSize (int width, int height) {
-	checkWidget ();
-	setMinimumSize (new Point (width, height));
-}
-
-void setMinimumSizeInPixels (int width, int height) {
 	checkWidget ();
 	geometry.setMinWidth(Math.max (width, trimWidth ()) - trimWidth ());
 	geometry.setMinHeight(Math.max (height, trimHeight ()) - trimHeight ());
@@ -2700,14 +2684,9 @@ void setMinimumSizeInPixels (int width, int height) {
  * @since 3.1
  */
 public void setMinimumSize (Point size) {
-	checkWidget ();
-	setMinimumSizeInPixels (size);
-}
-
-void setMinimumSizeInPixels (Point size) {
 	checkWidget ();
 	if (size == null) error (SWT.ERROR_NULL_ARGUMENT);
-	setMinimumSizeInPixels (size.x, size.y);
+	setMinimumSize (size.x, size.y);
 }
 
 /**
@@ -2732,7 +2711,13 @@ void setMinimumSizeInPixels (Point size) {
  */
 public void setMaximumSize (int width, int height) {
 	checkWidget ();
-	setMaximumSize (new Point (width, height));
+	geometry.setMaxWidth(Math.max (width, trimWidth ()) - trimWidth ());
+	geometry.setMaxHeight(Math.max (height, trimHeight ()) - trimHeight ());
+	int hint = GDK.GDK_HINT_MAX_SIZE;
+	if (geometry.getMinWidth() > 0 || geometry.getMinHeight() > 0) {
+		hint = hint | GDK.GDK_HINT_MIN_SIZE;
+	}
+	GTK3.gtk_window_set_geometry_hints (shellHandle, 0, (GdkGeometry) geometry, hint);
 }
 
 /**
@@ -2758,25 +2743,9 @@ public void setMaximumSize (int width, int height) {
  * @since 3.116
  */
 public void setMaximumSize (Point size) {
-	checkWidget ();
-	setMaximumSizeInPixels (size);
-}
-
-void setMaximumSizeInPixels (Point size) {
 	checkWidget ();
 	if (size == null) error (SWT.ERROR_NULL_ARGUMENT);
-	setMaximumSizeInPixels (size.x, size.y);
-}
-
-void setMaximumSizeInPixels (int width, int height) {
-	checkWidget ();
-	geometry.setMaxWidth(Math.max (width, trimWidth ()) - trimWidth ());
-	geometry.setMaxHeight(Math.max (height, trimHeight ()) - trimHeight ());
-	int hint = GDK.GDK_HINT_MAX_SIZE;
-	if (geometry.getMinWidth() > 0 || geometry.getMinHeight() > 0) {
-		hint = hint | GDK.GDK_HINT_MIN_SIZE;
-	}
-	GTK3.gtk_window_set_geometry_hints (shellHandle, 0, (GdkGeometry) geometry, hint);
+	setMaximumSize (size.x, size.y);
 }
 
 /**

bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/widgets/TabItem.java

@@ -160,11 +160,6 @@ void destroyWidget () {
  */
 public Rectangle getBounds () {
 	checkWidget ();
-	return getBoundsInPixels ();
-}
-
-Rectangle getBoundsInPixels () {
-	checkWidget();
 	GtkAllocation allocation = new GtkAllocation ();
 	GTK.gtk_widget_get_allocation (handle, allocation);
 	int x = allocation.x;