-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong SVGs #101
Comments
Hello @Michael5601 , if this issue is still active, i would like to work on if please. |
Hey @IamLRBA I appreciate your help but I already posted a PR that fixes the issue in #102. The PR is not yet accepted. |
Alright @Michael5601, I'll be delighted to help on any other issue if ever you have one. |
Hi, I am working on a project to include vector graphics in the icon processing of Eclipse. This enables a project to fix/remake all the icons used in Eclipse as the state of the icons could be improved. If you are interested in graphic design and want a big task in collaboration with the Eclipse UI team, this could be something for you. An improvement of this scope would have huge impact in the Eclipse Community. |
Wow, that's amazing @Michael5601, I am a graphics design enthusiast and would very much love to be part and contribute to this project. |
Sounds great to me :) I will open an issue for this topic so we can gather some feedback and maybe split up the task in smaller packages. We also need to find out the requirements for a new set of icons. |
I opened the issue. It would be great if you could volunteer to contribute to the icons with a comment under the issue so that the other contributors can work with you. |
Thanks so much for the assist @Michael5601 |
As part of my analysis for introducing vector graphics in Eclipse, I discovered several SVGs that either contain issues or do not align with their corresponding PNGs. Fortunately, all these issues can be resolved by adjusting the SVG files themselves, eliminating the need for a pull request outside the
eclipse.platform.images
repository.The following SVGs are problematic:
pinned_ovr.svg in
org.eclipse.e4.ui.workbench.renderers.swt
:PNG:
SVG:
SVG opened in Inkscape:
build_exec.svg in
org.eclipse.pde.ui\icons\etool16
and its duplicate inorg.eclipse.ui.ide\icons\full\etool16
:org.eclipse.pde.ui\icons\obj16
with the same name does not have this issue.Icon displayed in Chrome (or rasterized with Batik):
SVG opened in Inkscape:
participant_rem.svg in
org.eclipse.team.ui\icons\full\elcl16
:rem_co.svg
inorg.eclipse.debug.ui\icons\full\elcl16
and it's duplicate inorg.eclipse.ui.console\icons\full\elcl16
. An easy solution would be to replaceparticipant_rem.svg
with one of these versions ofrem_co.svg
.PNG:
SVG of participant_rem:
SVG of rem_co:
The issues with
pinned_ovr
,build_exec
(including its duplicate), andparticipant_rem
are fixed in: #102The text was updated successfully, but these errors were encountered: