Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.20 build fails with flag -DWITH_THREADING=OFF #3139

Open
mzymon opened this issue Oct 17, 2024 · 2 comments
Open

v2.0.20 build fails with flag -DWITH_THREADING=OFF #3139

mzymon opened this issue Oct 17, 2024 · 2 comments

Comments

@mzymon
Copy link

mzymon commented Oct 17, 2024

v2.0.20 build fails on my windows machine with flag -DWITH_THREADING=OFF due to changes related with introduction of lib/pthread_compat.h.
Defines was renamed to "COMPAT_" and functions are not changed in all required places causing build failure.
e.g. in file actions.c line 158 there is still "pthread_mutex_lock" instead of "COMPAT_pthread_mutex_lock"
Previous definitions of those functions from lib/dummypthread.h were deleted in v2.0.20.

@mzymon
Copy link
Author

mzymon commented Oct 17, 2024

Created pull request with fix #3140

@ralight
Copy link
Contributor

ralight commented Oct 17, 2024

Sorry, I'm not sure how that happened. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants