Use quotes on project name #1600

[Bananeweizen]

Also fix 2 additional properties ending in blanks. One can be removed, the other should be trimmed and the blank be added in code.

Looks like this after the change:

[github-actions]

Test Results

107 files  ±0  107 suites  ±0   10m 18s ⏱️ +13s
662 tests ±0  652 ✔️ ±0  10 💤 ±0  0 ❌ ±0 
662 runs  ±0  651 ✔️ ±0  11 💤 ±0  0 ❌ ±0 

Results for commit 3bb89ee. ± Comparison against base commit 7b152e5.

♻️ This comment has been updated with latest results.

[laeubi]

@Bananeweizen can you explain why the quotes are required?

[Bananeweizen]

@laeubi an example is visible in the linked issue: #1600. project names with blanks are hard to read in the unquoted version. And quotes are used in many of the other m2e progress messages anyway.

@HannesWell The properties are used in NLS, which in turn uses MessageFormat. And that uses single quote ranges for escaped text:

Within a String, a pair of single quotes can be used to quote any arbitrary characters except single quotes. For example, pattern string "'{0}'" represents string "{0}", not a FormatElement. A single quote itself must be represented by doubled single quotes '' throughout a String.

https://docs.oracle.com/javase/8/docs/api/java/text/MessageFormat.html

[laeubi]

I'm not sure if the quotes make things better readable, maybe we should improve the message itself to be more expressive?

[Bananeweizen]

Well, I'm sure that the quotes make the message more readable. :) No need to extend the message, especially because that is only the detail progress message (the lower part of the progress bar), the "what" is in the upper part of the progress bar anyway.

[HannesWell]

Well, I'm sure that the quotes make the message more readable. :) No need to extend the message, especially because that is only the detail progress message (the lower part of the progress bar), the "what" is in the upper part of the progress bar anyway.

I share this assessment.
LGTM.

[HannesWell]

Thanks Michael.