profiling: add tool path settings in project properity for profiling #205
Conversation
|
Hello @laomaolaile To inevitably get this accepted you will need to sign the Eclipse Contributor Agreement for the e-mail you have attached to your github id. Details can be found here: https://www.eclipse.org/legal/ECA.php You will need to create an Eclipse account first if you haven't already. |
tools Signed-off-by: zhangzegang <[email protected]>
laomaolaile
force-pushed
the
feature/toolpath
branch
from
ba74365
to
36b8620
Compare
...unch.core/src/org/eclipse/linuxtools/tools/launch/core/factory/LinuxtoolsProcessFactory.java
Outdated
Show resolved
Hide resolved
...unch.core/src/org/eclipse/linuxtools/tools/launch/core/factory/LinuxtoolsProcessFactory.java
Outdated
Show resolved
Hide resolved
...launch.ui/src/org/eclipse/linuxtools/internal/tools/launch/ui/properties/messages.properties
Outdated
Show resolved
Hide resolved
|
Test results are expected with rpm and createrepo tests. These are being removed. |
|
@laomaolaile If you can get the requested changes in before Tuesday of next week, your patch can get into 2023-09 M1. Otherwise, it will have to wait until 2023-09 M2. |
|
@jjohnstn Okay, I'll finish it this week |
|
Test failures have nothing to do with this patch. |
|
Thanks @laomaolaile |
|
@laomaolaile You are using tab not spaces to indent code, and I found similar lines need to be adjusted. Maybe a new patch could be added to solve this
|
|
@fanghuaqi Yes, he has used tabs which actually is the right way to do it. The old code needs to be reformatted. I noticed this in reviewing but did not want extra reformatting along with the patch as it obfuscates the actual changes. Another formatting patch is required. I was going to do it prior to 2023-09 M1, but feel free if you wish. |
…clipse-linuxtools#205) * profiling: add tool path settings in project properity for profiling tools Signed-off-by: zhangzegang <[email protected]>
Try to resolve issue #181