MessageHandler interface enhancements #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Separate interfaces for c2d and d2c messages - CommandHandler and TelemetryHandler - Removed AzureSettings parameter from handler Init method, static parameters should be passed to handler constructors. - MessageHandler.Init method receives cloud connection info only (this is data that may not be known at the time of handler creation) - Device ID, Hostname, etc. - Simplified test methods Signed-off-by: Stoyan Zoubev <[email protected]>
Fixed PR review comments. - CloudConnectionInfo is not a pointer inside AzureConnectionSettings - fixed typo Signed-off-by: Stoyan Zoubev <[email protected]>
e-grigorov
suggested changes
Oct 14, 2022
stoyan-zoubev
force-pushed
the
messagehandler-interface
branch
from
97a892b to
df9e974
Compare
e-grigorov
suggested changes
Oct 14, 2022
Fixed PR review comments. - CloudConnectionInfo renamed to RemoteConnectionInfo - SharedAccessKey struct removed, not really needed (SharedAccessKeyName is not applicable for Azure IoT Hub device connection string. - SharedAccessKey is now just a []byte field. Signed-off-by: Stoyan Zoubev <[email protected]>
stoyan-zoubev
force-pushed
the
messagehandler-interface
branch
from
df9e974 to
43605c0
Compare
hristobojilov
approved these changes
Oct 14, 2022
e-grigorov
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#18] MessageHandler interface enhancements
Signed-off-by: Stoyan Zoubev [email protected]