Improved message handler pluggability #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- removed internal registries for telemetry and command handlers - launcher now expects to get handlers instead of using the internal registries - handlers.go moved from message/handlers/common to message/handlers, package changed to handlers, common directory deleted - packages command and telemetry merged into one package passthrough - message/handlers/command/passthrough_handler_*.go moved as message/handlers/passthrough/command_handler_*.go - message/handlers/telemetry/passthrough_handler_*.go moved as message/handlers/passthrough/telemetry_handler_*.go - "passthrough" strings inside the source files removed as it now matches the package name - removed unused stopRouter method from main.go Signed-off-by: Stoyan Zoubev <[email protected]>
hristobojilov
approved these changes
Oct 13, 2022
e-grigorov
suggested changes
Oct 13, 2022
e-grigorov
reviewed
Oct 13, 2022
- added some extra log messages in case of errors - fixed typos and text descriptions.
e-grigorov
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#17] Improve message handler pluggability
Signed-off-by: Stoyan Zoubev [email protected]