Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove specific message format restriction #16

Closed
stoyan-zoubev opened this issue Sep 19, 2022 · 0 comments · Fixed by #23, #24, #25, #26 or #27
Closed

Remove specific message format restriction #16

stoyan-zoubev opened this issue Sep 19, 2022 · 0 comments · Fixed by #23, #24, #25, #26 or #27
Assignees
@stoyan-zoubev
Labels
task Single unit of work
Milestone
M3

Comments

@stoyan-zoubev
Copy link
Contributor

Kanto Azure connector implementation seems to define some mandatory message format for cloud-to-device and device-to-cloud messages - envelope.go

This is a very custom and not open-standard format and there is no real reason for Kanto to stick firmly to it.
So it is better to delete this message envelope restriction and also delete/update the other source files that are related to it.
Here is some list of additional subtasks:

  • after deleting the specific message envelope, the command bus handler needs to be updated not to parse the incoming cloud messages to a certain format.
  • rework of the command passthrough handler to be generic so that is does not depend on a certain message format for cloud messages.
  • renaming some settings that are related to the specific message envelope, e.g. AllowedLocalTopicsListand AllowedCloudMessageTypesList
  • deleting source code that is not used by Kanto azure connector binary, e.g. things handlers, protobuf files, message mapper, etc.
  • deleting unused MessageMapperConfig setting as message mapper is to be removed too.
@e-grigorov e-grigorov added the task Single unit of work label Sep 19, 2022
@e-grigorov e-grigorov moved this to Todo in Eclipse Kanto Sep 19, 2022
@konstantina-gramatova konstantina-gramatova added this to the M3 milestone Sep 29, 2022
@e-grigorov e-grigorov mentioned this issue Oct 5, 2022
Closed
stoyan-zoubev added a commit to SoftwareDefinedVehicle/kanto-azure-connector that referenced this issue Oct 11, 2022
@stoyan-zoubev
Fixed compilation problems in test files built with tag things.
534d514 
Note: These files will be removed anyway with [eclipse-kanto#16].

Signed-off-by: Stoyan Zoubev <[email protected]>
stoyan-zoubev added a commit to SoftwareDefinedVehicle/kanto-azure-connector that referenced this issue Oct 11, 2022
@stoyan-zoubev
Fixed compilation problems in test files built with tag things.
7ef1ce9 
Note: These files will be removed anyway with [eclipse-kanto#16].

Signed-off-by: Stoyan Zoubev <[email protected]>
@stoyan-zoubev stoyan-zoubev moved this from Todo to In Progress in Eclipse Kanto Oct 11, 2022
stoyan-zoubev added a commit to SoftwareDefinedVehicle/kanto-azure-connector that referenced this issue Oct 11, 2022
@stoyan-zoubev
[eclipse-kanto#16] Delete specific message envelope and unused code.
6a957d5 
- deleted specific message envelope and updated command bus handler.
- deleted code that is not used by kanto azure connector binary, e.g. things handlers, protobuf files, message mapper, etc.
- reworked command passthrough handler to be generic so that is does not depend on a certain message format.
- renamed AllowedLocalTopicsList and AllowedCloudMessageTypesList settings to PassthroughTelemetryTopic and PassthroughCommandTopic.
- removed unused MessageMapperConfig setting.

Signed-off-by: Stoyan Zoubev <[email protected]>
stoyan-zoubev added a commit to SoftwareDefinedVehicle/kanto-azure-connector that referenced this issue Oct 11, 2022
@stoyan-zoubev
[eclipse-kanto#16] Remove specific message format restriction
af216d9 
- deleted specific message envelope and updated command bus handler.
- deleted code that is not used by kanto azure connector binary, e.g. things handlers, protobuf files, message mapper, etc.
- reworked command passthrough handler to be generic so that is does not depend on a certain message format.
- renamed AllowedLocalTopicsList and AllowedCloudMessageTypesList settings to PassthroughTelemetryTopic and PassthroughCommandTopic.
- removed unused MessageMapperConfig setting.

Signed-off-by: Stoyan Zoubev <[email protected]>
@stoyan-zoubev stoyan-zoubev mentioned this issue Oct 11, 2022
Merged
@e-grigorov e-grigorov linked a pull request Oct 11, 2022 that will close this issue
Removed specific message envelope and unused code #23
Merged
@e-grigorov e-grigorov moved this from In Progress to Ready for Review in Eclipse Kanto Oct 11, 2022
stoyan-zoubev added a commit to SoftwareDefinedVehicle/kanto-azure-connector that referenced this issue Oct 11, 2022
@stoyan-zoubev
[eclipse-kanto#16] Removed specific message envelope and unused code
4ddc975 
- deleted command things handler that is not used by kanto azure connector binary
- deleted test cases for code that is not used

Signed-off-by: Stoyan Zoubev <[email protected]>
@stoyan-zoubev stoyan-zoubev mentioned this issue Oct 11, 2022
Merged
e-grigorov pushed a commit that referenced this issue Oct 11, 2022
@stoyan-zoubev
Removed unused code - command things handler (#24)
54cf2f0 
[#16] Removed specific message envelope and unused code

- deleted command things handler that is not used by kanto azure connector binary
- deleted test cases for code that is not used

Signed-off-by: Stoyan Zoubev <[email protected]>
@e-grigorov e-grigorov linked a pull request Oct 11, 2022 that will close this issue
Removed unused code - command things handler #24
Merged
stoyan-zoubev added a commit to SoftwareDefinedVehicle/kanto-azure-connector that referenced this issue Oct 11, 2022
@stoyan-zoubev
[eclipse-kanto#16] Removed specific message envelope and unused code
1a6cd52 
- deleted telemetry things handler that is not used by kanto azure connector binary
- deleted test cases for code that is not used either

Signed-off-by: Stoyan Zoubev [email protected]
@stoyan-zoubev stoyan-zoubev mentioned this issue Oct 11, 2022
Merged
stoyan-zoubev added a commit to SoftwareDefinedVehicle/kanto-azure-connector that referenced this issue Oct 11, 2022
@stoyan-zoubev
[eclipse-kanto#16] Removed specific message envelope and unused code
befd9cd 
- deleted message mapper that is not used by kanto azure connector binary
- deleted message protobuf marshaller as it is not used by kanto azure connector binary
- deleted test cases for code that is not used either

Signed-off-by: Stoyan Zoubev <[email protected]>
stoyan-zoubev added a commit to SoftwareDefinedVehicle/kanto-azure-connector that referenced this issue Oct 11, 2022
@stoyan-zoubev
[eclipse-kanto#16] Removed specific message envelope and unused code
3160d8d 
- deleted message mapper that is not used by kanto azure connector binary
- deleted message protobuf marshaller as it is not used by kanto azure connector binary
- deleted test cases for code that is not used either

Signed-off-by: Stoyan Zoubev <[email protected]>
@stoyan-zoubev stoyan-zoubev mentioned this issue Oct 11, 2022
Merged
stoyan-zoubev added a commit to SoftwareDefinedVehicle/kanto-azure-connector that referenced this issue Oct 11, 2022
@stoyan-zoubev
[eclipse-kanto#16] Removed specific message envelope and unused code
8f46d98 
- deleted message mapper that is not used by kanto azure connector binary
- deleted message protobuf marshaller as it is not used by kanto azure connector binary
- deleted test cases for code that is not used either

Signed-off-by: Stoyan Zoubev <[email protected]>
e-grigorov pushed a commit that referenced this issue Oct 12, 2022
@stoyan-zoubev
Removed unused code - telemetry things handler (#25)
98dd516 
[#16] Removed specific message envelope and unused code

- deleted telemetry things handler that is not used by kanto azure connector binary
- deleted test cases for code that is not used either

Signed-off-by: Stoyan Zoubev [email protected]
@e-grigorov e-grigorov linked a pull request Oct 12, 2022 that will close this issue
Removed unused code - telemetry things handler #25
Merged
@e-grigorov e-grigorov moved this from Ready for Review to In Review in Eclipse Kanto Oct 12, 2022
e-grigorov pushed a commit that referenced this issue Oct 12, 2022
@stoyan-zoubev
Removed unused code - message mapper and protobuf marshaller (#26)
fbf352b 
[#16] Removed specific message envelope and unused code

- deleted message mapper that is not used by kanto azure connector binary
- deleted message protobuf marshaller as it is not used by kanto azure connector binary
- deleted test cases for code that is not used either

Signed-off-by: Stoyan Zoubev <[email protected]>
@e-grigorov e-grigorov linked a pull request Oct 12, 2022 that will close this issue
Removed unused code - message mapper and protobuf marshaller #26
Merged
stoyan-zoubev added a commit to SoftwareDefinedVehicle/kanto-azure-connector that referenced this issue Oct 12, 2022
@stoyan-zoubev
[eclipse-kanto#16] Removed specific message envelope and unused code
5a3d0af 
- deleted unnecessary test resources - json and proto files

Signed-off-by: Stoyan Zoubev <[email protected]>
@stoyan-zoubev stoyan-zoubev mentioned this issue Oct 12, 2022
Merged
e-grigorov pushed a commit that referenced this issue Oct 12, 2022
@stoyan-zoubev
Removed unused test resource files (#27)
d41081f 
[#16] Removed specific message envelope and unused code

- deleted unnecessary test resources - json and proto files

Signed-off-by: Stoyan Zoubev <[email protected]>
@e-grigorov e-grigorov linked a pull request Oct 12, 2022 that will close this issue
Removed unused test resource files #27
Merged
e-grigorov pushed a commit that referenced this issue Oct 12, 2022
@stoyan-zoubev
Removed specific message envelope and unused code (#23)
5f4a78e 
[#16] Remove specific message format restriction

- deleted specific message envelope and updated command bus handler.
- deleted code that is not used by kanto azure connector binary, e.g. things handlers, protobuf files, message mapper, etc.
- reworked command passthrough handler to be generic so that is does not depend on a certain message format.
- renamed AllowedLocalTopicsList and AllowedCloudMessageTypesList settings to PassthroughTelemetryTopic and PassthroughCommandTopic.
- removed unused MessageMapperConfig setting.

Signed-off-by: Stoyan Zoubev <[email protected]>
Repository owner moved this from In Review to Done in Eclipse Kanto Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stoyan-zoubev stoyan-zoubev

Labels
task Single unit of work
Projects
Eclipse Kanto
Status: Done
Milestone
M3
3 participants
@e-grigorov @konstantina-gramatova @stoyan-zoubev