Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transmit whole preference section rather than individual fields #90

Open
colin-grant-work opened this issue Mar 1, 2024 · 0 comments
Open

Comments

@colin-grant-work
Copy link
Contributor

We are now transmitting quite a few separate preferences into the webview, and we're doing so by fetching every value we're interested in separately and then combining them into an object.

We could make that code less verbose if we simply fetched all of the preferences associated with the plugin at once and transmitted that to the webview:

return vscode.workspace.getConfiguration().get(manifest.PACKAGE_NAME) as OurMessageInterface;

The downside would be coupling between the package.json declarations and our data formats. But there's already a lot of coupling, since we're just pulling out the fields declared in the package.json one by one anyway.

Originally posted by @colin-grant-work in #89 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant