Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worth using something other than React? #15

Open
colin-grant-work opened this issue Feb 10, 2023 · 4 comments
Open

Worth using something other than React? #15

colin-grant-work opened this issue Feb 10, 2023 · 4 comments
Labels
question Further information is requested

Comments

@colin-grant-work
Copy link
Contributor

colin-grant-work commented Feb 10, 2023

Description

Most of the job of the Memory Inspector is rendering large lists of fairly uniform character. React isn't necessarily well suited to that task. We might achieve better performance and flexibility in managing our render cycles with a different DOM management strategy.

Additional information

@colin-grant-work colin-grant-work added the question Further information is requested label Feb 10, 2023
@thegecko
Copy link
Contributor

If it's mainly a table, perhaps there's a good component we could use to get sorting and paging for free?

@thegecko
Copy link
Contributor

The choice here was to use the vscode-ui-toolkit which ensures web views look like VS Code. This uses react under the hood.

@colin-grant-work
Copy link
Contributor Author

I think we can continue to use vscode-ui-toolkit even if we don't use React. It's actually twisting React a bit to integrate its own custom HTML elements, which are the core implementation of the VSCode-like UI elements, and I think we can also access those directly or through another wrapper.

@thegecko
Copy link
Contributor

I'm happy to follow your lead in this area. The tabular data is very important and I'd be interested to see what alternatives we have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants