Implementation of inferior PTY / IO needed #161
Labels
enhancement
New feature or request
Comments
|
Hmm the MI should really not be on the same channel as the program output. |
|
I believe no one has implemented this functionality yet - probably because most of the usecases for the adapter so far are embedded. On Linux probably want to use There is already PTY support needed by the Patches welcome. |
jonahgraham
changed the title
This was referenced Jan 31, 2023
jonahgraham
added a commit
to jonahgraham/cdt-gdb-adapter
that referenced
this issue
Feb 7, 2023
Using DAP's runInTerminal this PR adds the ability to use that new terminal for the inferior's I/O. The basic idea of the inferior terminal on Linux is: - adapter requests client (aka vscode) to create a terminal (using runInTerminal) - in that terminal we run a small script that "returns" the tty name to the adapter (using an atomically created file with the output of tty command) - then the script waits until the adapter is complete by monitoring the PID of the adapter's node process The script run in the terminal won't auto-stop when running the adapter in server mode (typically should only be used for development of the adapter) Part of eclipse-cdt-cloud#161
jonahgraham
added a commit
to jonahgraham/cdt-gdb-adapter
that referenced
this issue
Feb 7, 2023
Using DAP's runInTerminal this PR adds the ability to use that new terminal for the inferior's I/O. The basic idea of the inferior terminal on Linux is: - adapter requests client (aka vscode) to create a terminal (using runInTerminal) - in that terminal we run a small script that "returns" the tty name to the adapter (using an atomically created file with the output of tty command) - then the script waits until the adapter is complete by monitoring the PID of the adapter's node process The script run in the terminal won't auto-stop when running the adapter in server mode (typically should only be used for development of the adapter) Part of eclipse-cdt-cloud#161
2 tasks
|
I did a first pass of Linux support for this in #252. If anyone wants to review that to see what they think that would be much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Cannot distinguish program output from gdb mi output
cdt-gdb-adapterwould try to interpret every line as gdb mi output, which causes a problem because it cannot distinguish program output from that. For example:In the image above,
cdt-gdb-adaptertried to parse the line that's started with=or*, and failed.Only parse the output after a line is finished
According to:
https://github.com/eclipse-cdt/cdt-gdb-adapter/blob/3b9442075d06759035dbae616dbbd9923b921bc6/src/MIParser.ts#L26
the MIParser only handle the output when a line is finished. In the case of program output, this can be really buggy.
The text was updated successfully, but these errors were encountered: