Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] GUI - Resolve Attribute Reference Instead of Jump #67

Open
gerberm-at-msg opened this issue Oct 21, 2024 · 3 comments
Open

[FEATURE] GUI - Resolve Attribute Reference Instead of Jump #67

gerberm-at-msg opened this issue Oct 21, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@gerberm-at-msg
Copy link

Is your feature request related to a problem? Please describe.
When referencing to attributes, a "jump" button is displayed, to jump to the referenced attribute.

Describe the solution you'd like
For making the UI more user friendly, it would be nice if referenced values / attributes are directly displayed.
P.s. the Jump button is broken in the "AAS Viewer"-Mode, but works fine in "AAS Editor"

Example

image

 "submodels": [
    {
      "idShort": "icarryallinformation",
      "id": "https://msg.systems/ids/sm/5134_3181_0142_4482",
      "kind": "Instance",
      "submodelElements": [
        {
          "idShort": "CompanyName",
          "displayName": [
            {
              "language": "en",
              "text": "Description in English"
            },
            {
              "language": "de",
              "text": "Beschreigung in Deutsch"
            }
          ],
          "valueType": "xs:string",
          "value": "CompanyNameValue",
          "modelType": "Property"
        }
      ],
      "modelType": "Submodel"
    },
    {
      "idShort": "Ireadinformation",
      "id": "https://msg.systems/ids/sm/0264_3181_0142_2492",
      "kind": "Instance",
      "submodelElements": [
        {
          "idShort": "CompanyNameLink",
          "displayName": [
            {
              "language": "en",
              "text": "Linked Information Read"
            },
            {
              "language": "de",
              "text": "Verlinke Informationen lesen"
            }
          ],
          "embeddedDataSpecifications": [
            {
              "dataSpecification": {
                "type": "ModelReference",
                "keys": []
              },
              "dataSpecificationContent": {
                "preferredName": [],
                "modelType": "DataSpecificationIec61360"
              }
            }
          ],
          "value": {
            "type": "ModelReference",
            "keys": [
              {
                "type": "Submodel",
                "value": "https://msg.systems/ids/sm/5134_3181_0142_4482"
              },
              {
                "type": "Property",
                "value": "CompanyName"
              }
            ]
          },
          "modelType": "ReferenceElement"
        }
      ],
      "modelType": "Submodel"
    }
@gerberm-at-msg gerberm-at-msg added the enhancement New feature or request label Oct 21, 2024
@gerberm-at-msg gerberm-at-msg changed the title [FEATURE] GUI - Resolve Attribute Reference instead of Jump [FEATURE] GUI - Resolve Attribute Reference Instead of Jump Oct 21, 2024
@aaronzi
Copy link
Member

aaronzi commented Oct 23, 2024

Hello @gerberm-at-msg,

thank you for the bug report and the suggestion.
We will try to fix the bug ASAP and discuss resolving references in place.
This feature would probably introduce some challenges. When just a property is referenced I see no issues but how should references to an entire Submodel or an AAS be handled?

@aaronzi aaronzi transferred this issue from eclipse-basyx/basyx-java-server-sdk Oct 23, 2024
@gerberm-at-msg
Copy link
Author

Great thank you.

This feature would probably introduce some challenges. When just a property is referenced I see no issues but how should references to an entire Submodel or an AAS be handled?

I think in a perfect world they would be "inserted" as they are part and not referenced. To keep track, they could have a label with the reference. This would be a great step towards aggregation of DT. It would be probably a subsequent / recursive request.

@aaronzi
Copy link
Member

aaronzi commented Oct 24, 2024

That's an interesting idea. So you mean that I can basically unfold the reference element like a Submodel or collection and navigate deeper down from there. That could work but nevertheless it would be a challenging task.

I will add this to our backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: AAS Web UI
Development

No branches or pull requests

2 participants