From 34f13a411999378c60eb7c843b99959bc835c064 Mon Sep 17 00:00:00 2001 From: Conrad Bell IV Date: Sun, 12 Sep 2021 16:16:49 -0500 Subject: [PATCH 1/2] Added default values in parent pom for maven.gpg.skip and maven.source.skip --- CONTRIBUTING.md | 10 ++++++++-- aspectjmatcher/pom.xml | 15 ++++----------- aspectjrt/pom.xml | 11 +++++------ aspectjtools/pom.xml | 9 ++++----- aspectjweaver/pom.xml | 7 +++---- installer/pom.xml | 7 +++---- pom.xml | 28 ++++++++++++++++------------ 7 files changed, 43 insertions(+), 44 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a90ea46fa1..19f80c0286 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -11,7 +11,8 @@ AspectJ is a maven project, as such it should import cleanly into your IDE. The Simply run the maven project importer and point it at the root of the cloned AspectJ repository. This will import all of the AspectJ modules. -Each module comes with its own testsuites however there is a module called `run-all-junit-tests` - within there is a file `RunTheseBeforeYouCommitTests` which you can launch as a JUnit test (rightclick -> RunAs -> Junit Test). +Each module comes with its own test suite, however there is a module called `run-all-junit-tests` - within there is a +file `RunTheseBeforeYouCommitTests` which you can launch as a JUnit test (rightclick -> RunAs -> Junit Test). This will run a few thousand tests to verify your IDE import. Some tests are conditional based on the JDK you are using in your IDE since they are exercising features only available in recent Java. @@ -20,7 +21,12 @@ A JRE will likely not suffice because tools like javadoc will be invoked from th #### IntelliJ -TODO +Create a new project on the welcome screen with the `Get from VCS` button or within the IDE from `File | New | +Project from version control…` IntelliJ will recognize AspectJ as a multi-module maven project and import it as such. +To build, create a run/debug configuration with the command line set to `clean install` and other settings as +appropriate. If you have multiple JDKs installed, on the `Runner` tab select the desired JDK for the build, set +`JAVA_HOME` to match, and uncheck `Skip Tests`. Before running the build, select the profile matching your JDK in +the maven pane (or put on the command line in your run/debug configuration with `-P`). ### Developing tests diff --git a/aspectjmatcher/pom.xml b/aspectjmatcher/pom.xml index 1b504f0266..63d9d4338a 100644 --- a/aspectjmatcher/pom.xml +++ b/aspectjmatcher/pom.xml @@ -47,10 +47,9 @@ - + + false false - - false @@ -94,8 +93,6 @@ true --> - - org/aspectj/matcher/ @@ -148,6 +145,7 @@ true + ${maven.source.skip} @@ -171,11 +169,6 @@ copy - ${maven.javadoc.skip} true @@ -270,7 +263,7 @@ - + true diff --git a/aspectjrt/pom.xml b/aspectjrt/pom.xml index ab8eeb8b4a..b8a02ba3f9 100644 --- a/aspectjrt/pom.xml +++ b/aspectjrt/pom.xml @@ -46,10 +46,9 @@ - - false - - false + + false + false @@ -235,8 +234,8 @@ org.sonatype.plugins nexus-staging-maven-plugin - + @@ -263,7 +262,7 @@ - + true diff --git a/aspectjtools/pom.xml b/aspectjtools/pom.xml index 662bfa02d2..8ac3fa801e 100644 --- a/aspectjtools/pom.xml +++ b/aspectjtools/pom.xml @@ -48,10 +48,9 @@ - - false - - false + + false + false @@ -344,7 +343,7 @@ - + true diff --git a/aspectjweaver/pom.xml b/aspectjweaver/pom.xml index 4f9dd6ecd1..997e8a5531 100644 --- a/aspectjweaver/pom.xml +++ b/aspectjweaver/pom.xml @@ -46,10 +46,9 @@ - + + false false - - false @@ -344,7 +343,7 @@ - + true diff --git a/installer/pom.xml b/installer/pom.xml index db736e7d27..f93721ee1b 100644 --- a/installer/pom.xml +++ b/installer/pom.xml @@ -52,10 +52,9 @@ ones from aspectjtools, because the installer contains runtime, weaver and tools and the latter one is a superset of the former two. --> - - - - + + + diff --git a/pom.xml b/pom.xml index 2e7060f68e..062a287faf 100644 --- a/pom.xml +++ b/pom.xml @@ -15,10 +15,13 @@ UTF-8 UTF-8 - + + true true - + + true + true 1.9.7.M2 @@ -144,22 +147,22 @@ run-all-junit-tests docs - + aspectjrt aspectjweaver aspectjtools aspectjmatcher - + installer + Note: We can check if automatic profile activation works via mvn help:active-profiles. + --> jdk-8-to-15 @@ -189,6 +192,7 @@ org.apache.maven.plugins + maven-gpg-plugin @@ -332,8 +336,8 @@ sign - - ${maven.gpg.skip} + + ${maven.gpg.skip} @@ -492,8 +496,8 @@ junit From bb9f1ba5401b1a6d1e3b86e833b784de230ea75a Mon Sep 17 00:00:00 2001 From: Conrad Bell IV Date: Sun, 12 Sep 2021 16:16:49 -0500 Subject: [PATCH 2/2] Added default values in parent pom for maven.gpg.skip and maven.source.skip --- CONTRIBUTING.md | 10 ++++++++-- aspectjmatcher/pom.xml | 15 ++++----------- aspectjrt/pom.xml | 11 +++++------ aspectjtools/pom.xml | 9 ++++----- aspectjweaver/pom.xml | 7 +++---- installer/pom.xml | 7 +++---- pom.xml | 33 +++++++++++++++++++-------------- 7 files changed, 46 insertions(+), 46 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a90ea46fa1..19f80c0286 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -11,7 +11,8 @@ AspectJ is a maven project, as such it should import cleanly into your IDE. The Simply run the maven project importer and point it at the root of the cloned AspectJ repository. This will import all of the AspectJ modules. -Each module comes with its own testsuites however there is a module called `run-all-junit-tests` - within there is a file `RunTheseBeforeYouCommitTests` which you can launch as a JUnit test (rightclick -> RunAs -> Junit Test). +Each module comes with its own test suite, however there is a module called `run-all-junit-tests` - within there is a +file `RunTheseBeforeYouCommitTests` which you can launch as a JUnit test (rightclick -> RunAs -> Junit Test). This will run a few thousand tests to verify your IDE import. Some tests are conditional based on the JDK you are using in your IDE since they are exercising features only available in recent Java. @@ -20,7 +21,12 @@ A JRE will likely not suffice because tools like javadoc will be invoked from th #### IntelliJ -TODO +Create a new project on the welcome screen with the `Get from VCS` button or within the IDE from `File | New | +Project from version control…` IntelliJ will recognize AspectJ as a multi-module maven project and import it as such. +To build, create a run/debug configuration with the command line set to `clean install` and other settings as +appropriate. If you have multiple JDKs installed, on the `Runner` tab select the desired JDK for the build, set +`JAVA_HOME` to match, and uncheck `Skip Tests`. Before running the build, select the profile matching your JDK in +the maven pane (or put on the command line in your run/debug configuration with `-P`). ### Developing tests diff --git a/aspectjmatcher/pom.xml b/aspectjmatcher/pom.xml index 1b504f0266..63d9d4338a 100644 --- a/aspectjmatcher/pom.xml +++ b/aspectjmatcher/pom.xml @@ -47,10 +47,9 @@ - + + false false - - false @@ -94,8 +93,6 @@ true --> - - org/aspectj/matcher/ @@ -148,6 +145,7 @@ true + ${maven.source.skip} @@ -171,11 +169,6 @@ copy - ${maven.javadoc.skip} true @@ -270,7 +263,7 @@ - + true diff --git a/aspectjrt/pom.xml b/aspectjrt/pom.xml index ab8eeb8b4a..b8a02ba3f9 100644 --- a/aspectjrt/pom.xml +++ b/aspectjrt/pom.xml @@ -46,10 +46,9 @@ - - false - - false + + false + false @@ -235,8 +234,8 @@ org.sonatype.plugins nexus-staging-maven-plugin - + @@ -263,7 +262,7 @@ - + true diff --git a/aspectjtools/pom.xml b/aspectjtools/pom.xml index 662bfa02d2..8ac3fa801e 100644 --- a/aspectjtools/pom.xml +++ b/aspectjtools/pom.xml @@ -48,10 +48,9 @@ - - false - - false + + false + false @@ -344,7 +343,7 @@ - + true diff --git a/aspectjweaver/pom.xml b/aspectjweaver/pom.xml index 4f9dd6ecd1..997e8a5531 100644 --- a/aspectjweaver/pom.xml +++ b/aspectjweaver/pom.xml @@ -46,10 +46,9 @@ - + + false false - - false @@ -344,7 +343,7 @@ - + true diff --git a/installer/pom.xml b/installer/pom.xml index db736e7d27..f93721ee1b 100644 --- a/installer/pom.xml +++ b/installer/pom.xml @@ -52,10 +52,9 @@ ones from aspectjtools, because the installer contains runtime, weaver and tools and the latter one is a superset of the former two. --> - - - - + + + diff --git a/pom.xml b/pom.xml index 2e7060f68e..8b54dd83e2 100644 --- a/pom.xml +++ b/pom.xml @@ -1,6 +1,7 @@ - + 4.0.0 org.aspectj @@ -15,10 +16,13 @@ UTF-8 UTF-8 - + + true true - + + true + true 1.9.7.M2 @@ -144,22 +148,22 @@ run-all-junit-tests docs - + aspectjrt aspectjweaver aspectjtools aspectjmatcher - + installer + Note: We can check if automatic profile activation works via mvn help:active-profiles. + --> jdk-8-to-15 @@ -167,7 +171,7 @@ [1.8,16) - + @@ -189,6 +193,7 @@ org.apache.maven.plugins + maven-gpg-plugin @@ -332,7 +337,7 @@ sign - + ${maven.gpg.skip} @@ -492,8 +497,8 @@ junit