Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

Flutter SDK preference control misbehaves #164

Open
cybersearch2 opened this issue Jan 25, 2020 · 2 comments
Open

Flutter SDK preference control misbehaves #164

cybersearch2 opened this issue Jan 25, 2020 · 2 comments
Labels
area:dart area:flutter bug Something isn't working

Comments

@cybersearch2
Copy link

I am testing the 'wip_flutter' branch. When I use the 'Browse' button on the Flutter SDK preference field, the text remains blank after having made the selection. I am running Eclipse on Windows and assume the cause of this bug is operating-system-specific. An initial investigation reveals that the first event to occur after dismissing the Directory Dialog is a focus event and validation of the text control contents commences before the text control has been updated.

I also see the directory validation involves performing file operations, so I propose showing a busy cursor while the validation happens in the background so as not to block the UI thread.

I will present a a pull request once a fix is available.

@jonas-jonas
Copy link
Contributor

Thanks for the report.

The whole branch is kind of outdated, as I have been experimenting with a fix for an issue (#165) we ran into in the platform. Which involved moving a lot of the separated logic back to the base package. I will hopefully be able to push these changes in the next couple of days and update you on the progress here. After that this issue should be resolved though.

@cybersearch2
Copy link
Author

Thanks for the update. A fix is now ready to be offered as a pull request. It applies to both Dart and Flutter preferences as they are very similar to each other. Both launch a command shell to test that Dart is installed which is inadmissible inside a button-click handler.

I have moved the command shell code inside a busy cursor and that makes the edit field behave as expected. I also removed the default button from the Flutter page as there is no suitable default.

@jonas-jonas jonas-jonas added area:dart area:flutter bug Something isn't working labels Jan 28, 2020
cybersearch2 pushed a commit to cybersearch2/dartboard that referenced this issue Feb 6, 2020
…n portability eclipse-archived#169

Signed-off-by: Andrew Bowley <[email protected]>

* Two new OS-specific packages org.eclipse.dartboard.os.linux/windows
* New PlatformUtil class hides portability solution
* New DartSdkChecker and SdkLocator classes support preferences access
to SDK installations
* SDKLocator (note different to SdkLocator) no longer needed, so removed
* Solved preference field editor issues with executing shell command in
validation eg. re-entry caused by SWT event handling
* Improvements DartPreferencePageTest including new WaitCondition for
transition from displaying error to clearing the error
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:dart area:flutter bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants