-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freezor/bugfix/fix cannot upate properties #235 #238
Closed
Freezor
wants to merge
20
commits into
eclipse-aaspe:main
from
Freezor:freezor/bugfix/fix-cannot-upate-properties-#235
Closed
Freezor/bugfix/fix cannot upate properties #235 #238
Freezor
wants to merge
20
commits into
eclipse-aaspe:main
from
Freezor:freezor/bugfix/fix-cannot-upate-properties-#235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperties-#235 # Conflicts: # src/AasxServerStandardBib/Services/SubmodelService.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several changes aimed at improving testability, readability, and maintainability of the codebase. It introduces new unit tests for
IO.Swagger.Lib.V3
components, refactors existing code to adhere to best practices and design patterns, and removes unused methods to reduce clutter.Motivation and Context
The motivation behind this pull request is to enhance the overall quality of the codebase by introducing comprehensive unit tests, refactoring complex and redundant code, and ensuring adherence to established design principles. These changes were necessary due to the current state of the code, which has become difficult to maintain and lacks proper test coverage.
Fixes # (issue)
I started this because I tried to fix #235, but it seems that the issue is not on that side of the code, but the issue starts much deeper in the creation of AAS files. But to not loose the changes I created this PR and I still think they are useful.
Type of change
How Has This Been Tested?
The changes have been tested extensively using unit tests that cover various components of the
IO.Swagger.Lib.V3
project. Additionally, manual testing has been performed to ensure that the refactored code behaves as expected in different scenarios.Screenshots (if appropriate):
Checklist: