Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]Data specification IEC61360 id does not work due to case sensitivity. #196

Closed
JS-Aibel opened this issue Apr 4, 2024 · 6 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@JS-Aibel
Copy link

JS-Aibel commented Apr 4, 2024

Describe the bug
According to “IDTA-01003-a-3-0_SpecificationAssetAdministrationShell_Part3a_DataSpecification_IEC61360”, the id of the Data Specification IEC61360 Template is https://admin-shell.io/DataSpecificationTemplates/DataSpecificationIec61360/3/0
By using the id, an error message in the Package Explorer (v2024-02-27) is saying that the
Data specification Reference could not be identified. Thus, no content attributes could be provided.

Expected behavior
By changing the letters IEC in the id to uppercase, Package Explorer is showing the attributes as expected.
https://admin-shell.io/DataSpecificationTemplates/DataSpecificationIEC61360/3/0

@JS-Aibel JS-Aibel added the bug Something isn't working label Apr 4, 2024
@juileetikekar juileetikekar self-assigned this May 10, 2024
@juileetikekar
Copy link
Contributor

Hi @JS-Aibel,

Could you please provide steps to reproduce, respective logs and screenshots for this issue?

@juileetikekar juileetikekar added the Needs: Author Feedback Waiting for information/ feeadback from issue's author label May 10, 2024
@JS-Aibel
Copy link
Author

JS-Aibel commented May 10, 2024

Hi, @juileetikekar

  1. Create a Concept Description with HasDataSpesification of type “DataSpecificationIEC61360”.
  • If the id https://admin-shell.io/DataSpecificationTemplates/DataSpecificationIec61360/3/0 is used, an error message occurs as shown below.

image

  • If the id https://admin-shell.io/DataSpecificationTemplates/DataSpecificationIEC61360/3/0 is used, the ConceptDescription behaves as expected.
  1. When changing ids, make sure to save the file to see the effect.

The difference between the two ids is the uppercase letters EC in the word DataSpecificationIEC61360.

@MichaelHoffmeisterFesto
Copy link
Contributor

Hello,

thanks for reporting this bug! It seems to be pretty severe. According to the latest spec, it is not only about case-mismatch of "IEC" vs "Iec", but also the scheme changed from scheme "http://" to "https://" (Spec 01003-a-3-0 from March 2023).
I would assume, that the Package Explorer implemented the (pre-liminary) URI and the spec changed this during the process without noticing.
As a result, I assume that a large number of wrong data specs are now in the wild.

For the current branch (MIHO/Post_XMAS2023_Bugfixes) I've now changed this. The AASPE uses the correct URI as a preset and takes both variants ("http://" and "https://") with case-insensitive matching.

@juileetikekar juileetikekar removed the Needs: Author Feedback Waiting for information/ feeadback from issue's author label May 13, 2024
@BirgitBoss
Copy link
Contributor

Please also see this issue for the specification of the data specification itself:
admin-shell-io/aas-specs-iec61360#2 (comment)
We will provide a bugfix allowing both variants, with http and https. But probably we missed the Iec and IEC part.

@BirgitBoss
Copy link
Contributor

Bugfix V3.0.2 of Part 3a and Bugfix V3.0.1 of Part 1 are now released. I hope that #233 will fix this issue as well.

@MichaelHoffmeisterFesto
Copy link
Contributor

I hope I've fixed it now in the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants