Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove use of in-memory watermark #451

Open
stephengaudet opened this issue Sep 12, 2023 · 0 comments
Open

remove use of in-memory watermark #451

stephengaudet opened this issue Sep 12, 2023 · 0 comments
Assignees

Comments

@stephengaudet
Copy link
Contributor

stephengaudet commented Sep 12, 2023

when v1.1.0 was patched to v1.1.1 to remove order from the watermark, there was a change introduced that was not related to the defect fix.
the recent change was to only read the watermark file on startup, and then maintain it's state in memory.

conversation with Sam Weeks, we learned that it is desirable to have a many:one relationship between signatory services and the watermark file. where many signatory instances all use the same watermark file, either located on a network drive, or a cloud database.

the in-memory watermark does not work for the scenario of many signatory services backed by the same watermark file. for this scenario to work, signatory must consult the watermark file on every request, not on startup only.

priority: lower than any changes for Oxford's Adaptive Issuance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants