Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved error messaging when ledger is asleep #338

Open
stephengaudet opened this issue Mar 24, 2023 · 0 comments
Open

improved error messaging when ledger is asleep #338

stephengaudet opened this issue Mar 24, 2023 · 0 comments

Comments

@stephengaudet
Copy link
Contributor

steps to reproduce:

1.have ledger vault configured. use a low value for ledger vault close_after
2.start signatory
3.wait some time longer than close_after and ledger screen saver is on
5.curl :6732/keys/<well_formatted_but_nonexistent_pkh>

expected:
the error message when a key cannot be found is:
[{"id":"failure","kind":"temporary","msg":"this key not found in any vault"}]
we could include with that something to the effect "Please unlock the ledger device it could not be queried"

actual:
% curl localhost:6732/keys/tz2GLxED2Nx5Mtii3dFXhcHy4Rt8cHMBtpYb
[{"id":"failure","kind":"temporary","msg":"(Ledger/): [0x6400]: Unknown error"}]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant