Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some issue with DAL attestation with Quebec protocol #3

Open
saroupille opened this issue Jan 22, 2025 · 3 comments
Open

Some issue with DAL attestation with Quebec protocol #3

saroupille opened this issue Jan 22, 2025 · 3 comments
Assignees

Comments

@saroupille
Copy link

saroupille commented Jan 22, 2025

It was reported to us that there is an issue with Signatory on Quebec but not on Paris. A baker observed this just after the switch to Quebec:

Jan 21 21:43:49.261: unable to sign attestation for
Jan 21 21:43:49.261:   baker (<pkh>) at level 7703018, round 0
Jan 21 21:43:49.261:   --
Jan 21 21:43:49.261:   Error:
Jan 21 21:43:49.261:     Rpc request failed:
Jan 21 21:43:49.261:        - meth: POST
Jan 21 21:43:49.261:        - uri: http://aaa.bbb.ccc.ddd:6732/keys/<pkh>?authentication=<auth>
Jan 21 21:43:49.261:        - error: Oops! It looks like we forged an invalid HTTP request.
Jan 21 21:43:49.261:                   [{"id":"failure","kind":"temporary","msg":"gotez: unknown tag 23"}]

Looking for some difference between the two protocols, I was able to find this commit:

I was not able to find those lines on the corresponding operations file for Quebec protocol. Could it explain the issue?

@saroupille saroupille changed the title Some issue with DAL attestation Some issue with DAL attestation with Quebec protocol Jan 22, 2025
@e-asphyx e-asphyx self-assigned this Jan 22, 2025
@e-asphyx
Copy link
Contributor

I'm pretty sure it's fixed in the last release. Quebec package defines an alias pointing to the right implementation

type InlinedPreattestationContents = proto_018_Proxford.InlinedPreattestationContents

@saroupille
Copy link
Author

Why is it Oxford and not Paris?

@GImbrailo
Copy link

@saroupille what version of Signatory are you using?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants