Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Workbench Moderation" module is required and it shouldn't be #13

Open
mibocs opened this issue Nov 16, 2021 · 0 comments
Open

"Workbench Moderation" module is required and it shouldn't be #13

mibocs opened this issue Nov 16, 2021 · 0 comments

Comments

@mibocs
Copy link

mibocs commented Nov 16, 2021

I noticed that "Workbench Moderation" module is required for "NextEuropa Varnish" one. Can you tell me why this is needed if we don't use "Workbench Moderation" module at all?

/**
 * Implements hook_node_update().
 */
function nexteuropa_varnish_node_update($node) {
  // Ignore moderated nodes, they are handled by the workbench moderation hooks
  // implemented in this module.
  if (workbench_moderation_node_moderated($node)) {
    return;
  }

Why can't we just check if workbench module is enabled here?

I created a patch for this but i had to pack it because "patch" extension is not supported(accept=".gif,.jpeg,.jpg,.mov,.mp4,.png,.csv,.docx,.fodg,.fodp,.fods,.fodt,.gz,.log,.md,.odf,.odg,.odp,.ods,.odt,.pdf,.pptx,.txt,.xls,.xlsx,.zip").
digit-ne-varnish-make-workbench-optional.patch.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant