Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export serde_json::Value #404

Open
ReeceHumphreys opened this issue Jan 8, 2024 · 1 comment · May be fixed by #407
Open

Re-export serde_json::Value #404

ReeceHumphreys opened this issue Jan 8, 2024 · 1 comment · May be fixed by #407
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ReeceHumphreys
Copy link

Since some functions, such as configuration(&self, items: Vec<ConfigurationItem>) return types that contain serde_json::Value it would be useful to re-export this type.
@ebkalderon ebkalderon added enhancement New feature or request good first issue Good for newcomers labels Jan 10, 2024
@ebkalderon
Copy link
Owner

Seems like a nice idea! Thanks for the suggestion.

@ReeceHumphreys ReeceHumphreys linked a pull request Jan 10, 2024 that will close this issue
Open
@idealseal idealseal mentioned this issue Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add re-export for serde_json::Value ReeceHumphreys/tower-lsp
2 participants
@ebkalderon @ReeceHumphreys