Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix warnings in examples and vignettes #310

Merged
merged 13 commits into from
Oct 24, 2023

Conversation

strengejacke
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #310 (1769dfe) into main (ef50b6b) will increase coverage by 0.01%.
The diff coverage is 33.33%.

❗ Current head 1769dfe differs from pull request most recent head 71a0410. Consider uploading reports for the commit 71a0410 to get more accurate results

@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
+ Coverage   44.34%   44.35%   +0.01%     
==========================================
  Files          66       66              
  Lines        4758     4759       +1     
==========================================
+ Hits         2110     2111       +1     
  Misses       2648     2648              
Files Coverage Δ
R/plot.hdi.R 77.86% <ø> (ø)
R/plot.parameters_brms_meta.R 0.00% <ø> (ø)
R/plot.parameters_pca.R 87.87% <100.00%> (+0.18%) ⬆️
R/plot.si.R 43.83% <ø> (ø)
R/utils.R 68.91% <ø> (ø)
R/plot.parameters_model.R 27.21% <0.00%> (-0.09%) ⬇️
R/plot.visualisation_recipe.R 23.07% <50.00%> (+1.64%) ⬆️
R/print.check_model.R 0.00% <0.00%> (ø)

@strengejacke
Copy link
Member Author

@IndrajeetPatil How can I reproduce this issue with a longer traceback, so I know which seq_len() code is affected?

Quitting from lines 285-295 [unnamed-chunk-22] (parameters.Rmd)
Error in `map()`:
ℹ In index: 6.
ℹ With name: vignettes/parameters.Rmd.
Caused by error in `seq_len()`:
! (converted from warning) first element used of 'length.out' argument
Backtrace:
 1. parameters::model_parameters(ma)
 2. parameters:::model_parameters.rma(ma)
 3. parameters:::.model_parameters_generic(...)
 4. parameters:::.add_model_parameters_attributes(...)
 5. parameters:::.format_value_labels(params, model)
 6. insight::get_data(model, source = "mf", verbose = FALSE)
Execution halted

@strengejacke strengejacke merged commit 01041a2 into main Oct 24, 2023
24 of 26 checks passed
@strengejacke strengejacke deleted the fix_vignette_example_warnings branch October 24, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant