Update intercept detection and prior plotting

[bwiernik]

Fixes #297

I changed the regex from "starts with 'intercept'" to just "contains 'intercept'" so that it captures things like "b_intercept" and "b_zi_intercept".

I don't think it's a problem to not require intercept to be at the beginning--examples that I can think of where this would be a problem would be false positive captured just the same with the "starts with" restriction (e.g., "interception" in football modeling)

The x %in% .intercepts() part isn't really necessary at this point, but I left it in in the event that we come across a model class that uses a term other than intercept, such as "constant".

Edit: Also fixed the prior ridgeline plotting, which was ignoring the parameter argument from parameters table if supplied. This was also reported in #297.

[strengejacke]

I changed the regex from "starts with 'intercept'" to just "contains 'intercept'" so that it captures things like "b_intercept" and "b_zi_intercept".

Shouldn't that already work, see this helper function:

see/R/utils.R

Line 116 in 3c7ad13

.intercepts <- function() {

[bwiernik]

No, that set matches words exactly --the regex I proposed matches things like "intercept[2]" that appear for models like ordinal or multinomial in brms and other packages. Currently those models the intercept filtering fails. See the linked issue

[strengejacke]

examples that I can think of where this would be a problem would be false positive captured just the same with the "starts with" restriction (e.g., "interception" in football modeling)

What if we modify the regex like suggested in our discussion:
(?i)intercept[^a-zA-Z]
?

[bwiernik]

That's a good call. Will do that

[strengejacke]

No, that set matches words exactly

Yes, I know. I was just referring to your examples so that it captures things like "b_intercept" and "b_zi_intercept", which should be covered by the exact matches. The remaining cases should be covered by the regex.