posterior predictive check for binomial glm with matrix response

Fixes #644
easystats · Oct 29, 2023 · bfc8f8f · bfc8f8f
1 parent 5dc4f80
commit bfc8f8f
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Type: Package
 Package: performance
 Title: Assessment of Regression Models Performance
-Version: 0.10.7.1
+Version: 0.10.7.2
 Authors@R: 
     c(person(given = "Daniel",
              family = "Lüdecke",

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,16 @@
+# performance 0.10.8
+
+## Changes
+
+* Changed behaviour of `check_predictions()` for models from binomial family,
+  to get comparable plots for different ways of outcome specification. Now,
+  if the outcome is a proportion, or defined as matrix of trials and successes,
+  the produced plots are the same (because the models should be the same, too).
+
+## Bug fixes
+
+* Fixed CRAN check erros.
+
 # performance 0.10.7
 
 ## Breaking changes

diff --git a/R/check_predictions.R b/R/check_predictions.R
@@ -263,7 +263,7 @@ pp_check.glm <- function(object,
   out <- tryCatch(
     {
       matrix_sim <- stats::simulate(object, nsim = iterations, re.form = re_formula, ...)
-      as.data.frame(sapply(matrix_sim, function(i) i[, 1] / i[, 2], simplify = TRUE))
+      as.data.frame(sapply(matrix_sim, function(i) i[, 1] / rowSums(i, na.rm = TRUE), simplify = TRUE))
     },
     error = function(e) {
       NULL
@@ -285,7 +285,7 @@ pp_check.glm <- function(object,
   )
   resp_string <- insight::find_terms(object)$response
 
-  out$y <- response[, 1] / response[, 2]
+  out$y <- response[, 1] / rowSums(response, na.rm = TRUE)
 
   # safe information about model
   if (!is.null(model_info)) {