Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust/partialize by selected column #147

Closed
mattansb opened this issue Mar 17, 2021 · 3 comments
Closed

adjust/partialize by selected column #147

mattansb opened this issue Mar 17, 2021 · 3 comments
Labels
enhancement 💥 Implemented features can be improved or revised

Comments

@mattansb
Copy link
Member

Currently I can only partialize by all the "other" selected columns (the ones that aren't part of the correlation).

It would be nice to be able to "fix" which columns I want to partialize by.

For example, I can get multi-level correlations this way:

correlation::correlation(
  iris,
  partial_by = "Species", # <<<<<<<<<<<<
  partial = TRUE,
  multilevel = TRUE
)
@IndrajeetPatil IndrajeetPatil added the enhancement 💥 Implemented features can be improved or revised label Mar 19, 2021
@DominiqueMakowski
Copy link
Member

rather than adding a new arg partial_by I'd just allow partial to take in characters vectors:

correlation::correlation(iris, partial = "Species", multilevel = TRUE)

@jmgirard
Copy link

This was closed but didn't seem to have been implemented.

@mattansb
Copy link
Member Author

Closing in favor of #311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 💥 Implemented features can be improved or revised
Projects
None yet
Development

No branches or pull requests

4 participants