Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare CRAN release #655

Merged
merged 6 commits into from
Jul 24, 2024
Merged

Prepare CRAN release #655

merged 6 commits into from
Jul 24, 2024

Conversation

strengejacke
Copy link
Member

@DominiqueMakowski

Maybe you can submit this version to CRAN this week? Or are you unavailable the next days?

@strengejacke
Copy link
Member Author

@DominiqueMakowski I would not change the package dependencies (i.e. versions) in the DESCRIPTION file - if you rely on the latest datawizard (0.12.2), you get errors for Mac OS X. And I checked, bayestestR is not affected by the API changes in datawizard, so it's OK to rely on 0.10.0

@DominiqueMakowski
Copy link
Member

I can submit later today

@IndrajeetPatil
Copy link
Member

We need to include {cmdstanr} in suggested deps (Suggests) since some tests require it.

@strengejacke
Copy link
Member Author

We need to include {cmdstanr} in suggested deps (Suggests) since some tests require it.

That package is not on CRAN?

@strengejacke
Copy link
Member Author

@strengejacke
Copy link
Member Author

@DominiqueMakowski have you already submitted? If not, we could probably address #627 first.

@DominiqueMakowski
Copy link
Member

I'm holding out then

@strengejacke
Copy link
Member Author

ok, PR is merged into this branch. Once the regular tests pass, you could submit (windows/ubuntu latest release and devel, mac os latest).

@strengejacke
Copy link
Member Author

🟢

@strengejacke
Copy link
Member Author

🟢

(@DominiqueMakowski: means, you can submit... 😬 )

@DominiqueMakowski
Copy link
Member

submitted

@strengejacke
Copy link
Member Author

Just saw, on CRAN! Yay!

@strengejacke strengejacke merged commit 77a9766 into main Jul 24, 2024
18 of 22 checks passed
@strengejacke strengejacke deleted the rc_0_14_0 branch July 24, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants