Nbol48 flood return submission #390
Conversation
Updating changes to nbol48 branch 9.27.23
There was a problem hiding this comment.
Nice work Nathan. I would maybe recommend a few changes to your portfolio submission. Because the map is so large and first appears with no context when you open the page, you should really consider adding a markdown cell at the top of the page that includes a header/title and maybe some text for context.
In the body of your code, I would remove the print lines that show all the data tables and processing steps from each of your code blocks. You really only need the graph plots and more text describing them. Only the last plot has a short explanation. A little more detail here is useful. Suppressing the warnings in the pink boxes would also be helpful, but I myself am still struggling to figure out how to do that. The example provided in Elsa's video did not work for me. That's more of a suggestion than a need-to-change at this point.
Updating nbol48 Branch
|
good work with both your flooding on the Selway River, and Crescent Mountain Wildfire workflows, @nbol48 ! I would agree with @ellenalamont17 that you could think about adding a header of some kind above the folium map for the Selway flood. It looks like you did this for the NDVI workflow - nice! And, also I like @ellenalamont17 suggestion about removing the intermediate parts of the workflow and only focusing on the plot and headlines. This is a preference I suppose, and some others may prefer to have the code and outputs that build up to the plot. Again, nice work with these! I'm going to go ahead and merge this PR. Also, I'm not sure if @eculler wants folks to be submitting *separate pull requests for each assignment? I'm noticing that the NDVI submission is also part of the PR #390 (flood return submission). |
No description provided.