Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose properties optional parameter for commits made from python #611

Open
mpiannucci opened this issue Jan 23, 2025 · 2 comments
Open
Labels
python 🐍 Related to python code

Comments

@mpiannucci
Copy link
Contributor

In rust, users can associate extract data with commits using the properties parameter. This should be exposed to the python session

@mpiannucci mpiannucci added the python 🐍 Related to python code label Jan 23, 2025
@mpiannucci
Copy link
Contributor Author

There are two things to work around here:

  1. The properties of a snapshot are currently of type Hashmap<String, json::Value>. This type can be bridged into pythojn but there is no direct mapping currently.
  2. The properties of a snapshot are currently not stored with the metadata. This means they are not stored inside of children so if a children wants the ancestry including the properties of each commit, they must fetch the full snapshot for each snapshot in the history to do so. If we store the properties in the metadata` that has the side effect of potentially bloating the size of the snapshots because each snapshot holds the metadata of its ancestors

@paraseba
Copy link
Collaborator

One extra point: even if the spec allows to keep only part of the history in each snapshot, the current implementation keeps all of them. So every snapshot gets larger as the history tree grows. This is very much something we can improve on, but it's where we are at today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python 🐍 Related to python code
Projects
None yet
Development

No branches or pull requests

2 participants