Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting 2 authorities for taxcov make all fields NA #175

Open
yvanlebras opened this issue Nov 15, 2021 · 3 comments
Open

Selecting 2 authorities for taxcov make all fields NA #175

yvanlebras opened this issue Nov 15, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@yvanlebras
Copy link
Contributor

At least combining ITIS and GBIF, give a tabular metadata template with NA for "name_resolved", "authority_system" and "authority_ID" but making the same only selecting GBIF give non NA information for the same species name.

@yvanlebras
Copy link
Contributor Author

Maybe "just" a pb with ITIS ?

@earnaud
Copy link
Owner

earnaud commented Nov 16, 2021

I get the following when trying by hand on a single species:

> taxonomyCleanr::make_taxonomicCoverage("Salmo trutta fario", c("GBIF","ITIS"), write.file = FALSE)
Creating <taxonomicCoverage>
Retrieving classifications
Error in UseMethod("as.gbifid") : 
  no applicable method for 'as.gbifid' applied to an object of class "logical"

Also, this occurs with one or the other authority.

@clnsmth , any idea?

@clnsmth
Copy link
Contributor

clnsmth commented Nov 17, 2021

Hi @yvanlebras @earnaud

You'll need to call resolve_sci_taxa() first, then send the results to make_taxonomicCoverage().

Try ...

taxonomyCleanr::view_taxa_authorities()
r <- taxonomyCleanr::resolve_sci_taxa("Salmo trutta fario", data.sources = c(11, 3))
tc <- taxonomyCleanr::make_taxonomicCoverage(
  taxa.clean = r$taxa_clean,
  authority = r$authority, 
  authority.id = r$authority_id, 
  write.file = FALSE)

@earnaud earnaud added the bug Something isn't working label Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants