Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e_library_managerTest::testDetectionVersionConsistency() depends on the Internet #4560

Open
Deltik opened this issue Sep 10, 2021 · 0 comments · May be fixed by #4561
Open

e_library_managerTest::testDetectionVersionConsistency() depends on the Internet #4560

Deltik opened this issue Sep 10, 2021 · 0 comments · May be fixed by #4561
Labels
core: testing framework type: bug A problem that should not be happening

Comments

@Deltik
Copy link
Member

Deltik commented Sep 10, 2021 •
edited
Loading

Bug Description

The test e_library_managerTest::testDetectionVersionConsistency(), located in e107_tests/tests/unit/e_library_managerTest.php, downloads content from the Internet.

Unit tests should not depend on the Internet, as those resources may disappear or change and cause inconsistent testing behavior.

How to Reproduce

  1. Disconnect the test machine from the Internet.
  2. Run all unit tests.
  3. Observe the test failure: 
    There was 1 failure:

---------
1) e_library_managerTest: Detection version consistency
 Test  tests/unit/e_library_managerTest.php:testDetectionVersionConsistency
No looked-up version in core_library:config() -- cdn.jquery
Failed asserting that false is true.
#1  ~/Documents/Development/PhpstormProjects/e107/e107_tests/tests/unit/e_library_managerTest.php:84

FAILURES!
Tests: 707, Assertions: 4801, Failures: 1.

Expected Behavior

No Internet connection for any unit tests

Additional Context

This bug was introduced by 2f780fc.

Past fixes for tests depending on the Internet:
@Deltik Deltik added type: bug A problem that should not be happening core: testing framework labels Sep 10, 2021
Deltik added a commit to Deltik/e107 that referenced this issue Sep 10, 2021
@Deltik
e_library_managerTest::testDetectionVersionConsistency(): No Internet
996fc17 
Removed Internet dependency for test
`e_library_managerTest::testDetectionVersionConsistency()`

And now the test is actually useful because it can now detect the
version mismatch between the local copy and the CDN link

Fixes: e107inc#4560
@Deltik Deltik linked a pull request Sep 10, 2021 that will close this issue
Open
10 tasks
Deltik added a commit to Deltik/e107 that referenced this issue Oct 18, 2021
@Deltik
e_library_managerTest::testDetectionVersionConsistency(): No Internet
9af1207 
Removed Internet dependency for test
`e_library_managerTest::testDetectionVersionConsistency()`

And now the test is actually useful because it can now detect the
version mismatch between the local copy and the CDN link

Fixes: e107inc#4560
Deltik added a commit to Deltik/e107 that referenced this issue Oct 27, 2021
@Deltik
e_library_managerTest::testDetectionVersionConsistency(): No Internet
bd9b9a7 
Removed Internet dependency for test
`e_library_managerTest::testDetectionVersionConsistency()`

And now the test is actually useful because it can now detect the
version mismatch between the local copy and the CDN link

Fixes: e107inc#4560
Deltik added a commit to Deltik/e107 that referenced this issue Nov 25, 2021
@Deltik
e_library_managerTest::testDetectionVersionConsistency(): No Internet
ab3aca8 
Removed Internet dependency for test
`e_library_managerTest::testDetectionVersionConsistency()`

And now the test is actually useful because it can now detect the
version mismatch between the local copy and the CDN link

Fixes: e107inc#4560
Deltik added a commit to Deltik/e107 that referenced this issue Dec 3, 2021
@Deltik
e_library_managerTest::testDetectionVersionConsistency(): No Internet
bcc713b 
Removed Internet dependency for test
`e_library_managerTest::testDetectionVersionConsistency()`

And now the test is actually useful because it can now detect the
version mismatch between the local copy and the CDN link

Fixes: e107inc#4560
Deltik added a commit to Deltik/e107 that referenced this issue Jan 23, 2022
@Deltik
e_library_managerTest::testDetectionVersionConsistency(): No Internet
e25107c 
Removed Internet dependency for test
`e_library_managerTest::testDetectionVersionConsistency()`

And now the test is actually useful because it can now detect the
version mismatch between the local copy and the CDN link

Fixes: e107inc#4560
Deltik added a commit to Deltik/e107 that referenced this issue Jan 23, 2022
@Deltik
e_library_managerTest::testDetectionVersionConsistency(): No Internet
6fa7a9c 
Removed Internet dependency for test
`e_library_managerTest::testDetectionVersionConsistency()`

And now the test is actually useful because it can now detect the
version mismatch between the local copy and the CDN link

Fixes: e107inc#4560
Deltik added a commit to Deltik/e107 that referenced this issue Jan 23, 2022
@Deltik
e_library_managerTest::testDetectionVersionConsistency(): No Internet
3867dda 
Removed Internet dependency for test
`e_library_managerTest::testDetectionVersionConsistency()`

And now the test is actually useful because it can now detect the
version mismatch between the local copy and the CDN link

Fixes: e107inc#4560
Deltik added a commit to Deltik/e107 that referenced this issue Jul 28, 2022
@Deltik
e_library_managerTest::testDetectionVersionConsistency(): No Internet
8bc1bb4 
Removed Internet dependency for test
`e_library_managerTest::testDetectionVersionConsistency()`

And now the test is actually useful because it can now detect the
version mismatch between the local copy and the CDN link

Fixes: e107inc#4560
Deltik added a commit to Deltik/e107 that referenced this issue Sep 7, 2022
@Deltik
e_library_managerTest::testDetectionVersionConsistency(): No Internet
b4ab6a6 
Removed Internet dependency for test
`e_library_managerTest::testDetectionVersionConsistency()`

And now the test is actually useful because it can now detect the
version mismatch between the local copy and the CDN link

Fixes: e107inc#4560
Deltik added a commit to Deltik/e107 that referenced this issue Dec 15, 2022
@Deltik
e_library_managerTest::testDetectionVersionConsistency(): No Internet
c5da7e7 
Removed Internet dependency for test
`e_library_managerTest::testDetectionVersionConsistency()`

And now the test is actually useful because it can now detect the
version mismatch between the local copy and the CDN link

Fixes: e107inc#4560
Deltik added a commit to Deltik/e107 that referenced this issue Apr 13, 2023
@Deltik
e_library_managerTest::testDetectionVersionConsistency(): No Internet
dc634d3 
Removed Internet dependency for test
`e_library_managerTest::testDetectionVersionConsistency()`

And now the test is actually useful because it can now detect the
version mismatch between the local copy and the CDN link

Fixes: e107inc#4560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core: testing framework type: bug A problem that should not be happening
Projects
None yet
Milestone
No milestone
1 participant
@Deltik