Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for versioning and prefixing #63

Closed
virtosubogdan opened this issue Mar 9, 2016 · 1 comment
Closed

Support for versioning and prefixing #63

virtosubogdan opened this issue Mar 9, 2016 · 1 comment

Comments

@virtosubogdan
Copy link
Contributor

There should be an option to augment the prefix for static files.
This should be done by a static prefix and a dynamic option (for versioning).

The use case for the static prefix is that a bucket contains a lot of resources for many applications/environments.
It seems similar to #22, but because the static file location does not depend at all on the application logic, this is completely different.
The static files should be collected to /path_to_allowed_prefix/environment/static_files on the S3 bucket, where /path_to_allowed_prefix/environment/ should be specified by a setting.

The use case for versioning is the standard one. Appending a hash to the filename is an alternative, but the choice between hash appending and another prefix should be up to the flask-s3 user.
The proposition is to do this by another setting which will contain the path to the function where the user implements the versioning prefix.

All requests should add no overhead when collecting or using url_for for users that do not want to use them.

@Fuyukai
Copy link
Collaborator

Fuyukai commented Mar 26, 2016

Closed by #64

@Fuyukai Fuyukai closed this as completed Mar 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants