Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is not compatible with NC25 #250

Open
anguschang007 opened this issue Oct 25, 2022 · 12 comments
Open

It is not compatible with NC25 #250

anguschang007 opened this issue Oct 25, 2022 · 12 comments

Comments

@anguschang007
Copy link

Screenshot at Oct 25 21-04-13
The app is not compatible with NC25. The right side section is missing!

@Albirew
Copy link

Albirew commented Nov 1, 2022

On my side, i get an error 500-like, and an exception in logs
Exception: OC\Files\Utils\Scanner::__construct(): Argument #4 ($logger) must be of type Psr\Log\LoggerInterface, OC\Log given, called in /path-to-nxc/apps/ocdownloader/controller/index.php on line 249 in file '/path-to-nxc/lib/private/Files/Utils/Scanner.php' line 95

@anguschang007
Copy link
Author

On my side, i get an error 500-like, and an exception in logs Exception: OC\Files\Utils\Scanner::__construct(): Argument #4 ($logger) must be of type Psr\Log\LoggerInterface, OC\Log given, called in /path-to-nxc/apps/ocdownloader/controller/index.php on line 249 in file '/path-to-nxc/lib/private/Files/Utils/Scanner.php' line 95

#247

@weeman1337
Copy link
Contributor

weeman1337 commented Nov 2, 2022

There is not even proper support for 24 yet, although a ready PR exists #247 .There was a commit updating the app info without migrating the rest. I am removing myself as a collaborator @e-alfred . The reason is that I don't want to put time into this project if the work is ignored ☹️

@firebird76
Copy link

Screenshot at Oct 25 21-04-13 The app is not compatible with NC25. The right side section is missing!

@anguschang007: You can fix the problem: Change <div id="app"> in templates files to <div id="content">.

@MasterBean7
Copy link

MasterBean7 commented Nov 28, 2022

Thanks for point it out @firebird76
In fact, on my version NC25.0.1 it looks better if the <dav> is removed completely.
However, the automatic reload still creates a "glitch" effect.
And workaround #247 was needed.

@p-bo
Copy link

p-bo commented Dec 1, 2022

Just in case it wasn't noticed - Nextcloud improved policy regarding changes in core to ease app developers in maintaining compatibility with newer Nextcloud versions:

https://help.nextcloud.com/t/new-process-for-documenting-core-code-changes-that-affect-app-developers/149828?u=p-bo

@31337-4554551n
Copy link

I am also saddened this app isn't getting love. Commenting to get updates if this is ever resolved. This app was one of the reasons I love nextcloud.
@weeman1337 Are you aware of any forks perhaps? Any interest in creating your own? :P

@freechelmi
Copy link

NcDownloader is a good candidate https://apps.nextcloud.com/apps/ncdownloader

@31337-4554551n
Copy link

NcDownloader is a good candidate https://apps.nextcloud.com/apps/ncdownloader

You're an absolute legend! Had no idea this existed.

None of these have an android companion app though, do they?

@e-alfred
Copy link
Owner

Due to personal reasons, I did not have as much time during the last months for maintaining all the Nextcloud apps I used to do for several years now.

One mistake was to release of a bogus version without the required fix that should have been packaged. I am very sorry for that, but keeping up was not as easy as it was before. I hope I can do more releases in the future again.

@NTenic-Hadrev
Copy link

Just in case someone wants to try it. NCDownloader is not working well.

@meichthys
Copy link

Also for reference, not compatible with NC26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests