Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line editing: utf8 support, ctrl+arrows, all that jazz #2

Closed
dzwdz opened this issue Aug 5, 2023 · 1 comment
Closed

line editing: utf8 support, ctrl+arrows, all that jazz #2

dzwdz opened this issue Aug 5, 2023 · 1 comment

Comments

@dzwdz
Copy link
Owner

dzwdz commented Aug 5, 2023

This is the only major release blocker so I suppose I'll make it into a real issue.

hewwo currently uses linenoise for line editing, mostly because of its multiplexing API. As far as I can tell, neither editline nor readline have a similar feature. rlwrap does what we want here with readline, but it goes through a lot of trouble to do so. Thus, it might be best to stick with linenoise, as it already supports that out of the box.

Sadly, linenoise doesn't support many other things, e.g. utf8, or ctrl+arrows. There are forks with utf8 support (antirez/linenoise#186, antirez/linenoise#187), but they've all branched off before the multiplexing API got implemented.

A friend offered to try rebasing yhirose's utf8 patch onto the latest upstream version, so that's the current course of action. Maybe.

@dzwdz
Copy link
Owner Author

dzwdz commented Aug 10, 2023

closed by c0dd194

@dzwdz dzwdz closed this as completed Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant