Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add further attributes to the related publications #3249

Closed
AndyDaniel1 opened this issue Oct 17, 2023 · 10 comments
Closed

Add further attributes to the related publications #3249

AndyDaniel1 opened this issue Oct 17, 2023 · 10 comments

Comments

@AndyDaniel1
Copy link
Member

The following attributes should be added to the related publications:

  • doi (or other identificator / reference link)
  • split up source references: Author, Title, Issue, journal
@tilovillwock tilovillwock changed the title Add further attributes to the releated publications Add further attributes to the related publications Oct 23, 2023
@tilovillwock
Copy link
Collaborator

doi (or other identificator / reference link)

A DOI Link attribute seems to be already part of the type as far as I can tell. It seems that many publications simply lack the information. One example that has one: https://metadata.fdz.dzhw.eu/de/publications/pub-Engel.2023?page=1&size=10&type=data_packages

split up source references: Author, Title, Issue, journal

Could you expand on what needs to be split up? Do you want "Source Reference" to be replaced by Journal and Issue? Do we need to consider other publication types like books?

An example from prod:

Bildschirmfoto 2023-10-23 um 12 30 53

@AndyDaniel1

@AndyDaniel1
Copy link
Member Author

The source reference as a whole should remain, but next to it we should have separate fields for author, title, issue, journal (all not mandatory). It would be best if I provide the input format for the citations to get a better understanding of it

@AndyDaniel1
Copy link
Member Author

Check the import routine to get all relevant attributes

add abstract as optional

@tilovillwock
Copy link
Collaborator

According to @AndyDaniel1 the import process already combines citation attributes into a single "Source Reference" attribute so it should be possible to use this as a starting point. We need to find out if this happens on the frontend or backend.

Furthermore:

  • the attributes that were already mentioned are supposed to appear in their provided order before the "Source Reference" attribute
  • we also want to a add "Abstract" as an optional attribute

@tilovillwock
Copy link
Collaborator

tilovillwock commented Nov 20, 2023

@AndyDaniel1 we should discuss whether we need to consider a migration strategy for publications that have already been imported. This could lead to some unexpected outcomes. As far as I can tell Journal and Issue are not parsed and stored as separate attributes right now. As such we would have to parse the sourceReference Attribute for existing publications hoping that there are no deviations from the common format <Journal>, <Issue>.

It would also help if we could get an example Excel-File with relevant BibTex data. An example file can be found in the Wiki.

@ewolf47
Copy link
Collaborator

ewolf47 commented Dec 4, 2023

@AndyDaniel1
I added the new attributes to the related publication common-details page. Is the order of attributes correct?
image

Because the excel-file, that is used as import, does not provide any information about "journal" or "issue" I added a request to https://doi.org/<DOI> which returns multiple information about the publication. In my opinion, there a two possible fields, that can be used to fill the journal attribute. Either container-title or container-title-short. The latter seems to be just a shorter version of the actual journal name. Here is an example to clarify this: When I request with the doi "10.1007/s11577-017-0485-7" which belongs to this publication

de Vogel, S. (2017). Wie beeinflussen Geschlecht und Bildungsherkunft den Übergang in individuelle und strukturierte Promotionsformen? KZfSS Kölner Zeitschrift für Soziologie und Sozialpsychologie, 69(3), 437–471. https://doi.org/10.1007/s11577-017-0485-7

the container-title contains KZfSS Kölner Zeitschrift für Soziologie und Sozialpsychologie, while the container-title-short only contains Köln Z Soziol. So I decided to take the more detailed container-title. Is that in your interest?

Remark: If the DOI-column of a row in the excel-file, that is used as import, is not filled, there won't be any information about the journal and issue, because the https://doi.org/<DOI>-request can not be send.

ewolf47 added a commit that referenced this issue Dec 4, 2023
@AndyDaniel1
Copy link
Member Author

@ewolf47 thank you, good idea to retrieve the information from doi.org!

ℹ️ The order should be title; year; journal; issue.

the container-title contains KZfSS Kölner Zeitschrift für Soziologie und Sozialpsychologie, while the container-title-short only contains Köln Z Soziol. So I decided to take the more detailed container-title. Is that in your interest?

✔️ Yes, we should use the container-title (not the short version).

Remark: If the DOI-column of a row in the excel-file, that is used as import, is not filled, there won't be any information about the journal and issue, because the https://doi.org/-request can not be send.

✔️

@AndyDaniel1
Copy link
Member Author

Will leave the issue open until #3346 is resolved

@tilovillwock
Copy link
Collaborator

@AndyDaniel1 since the majority of this functionality has already been deployed to production and we're discussing other possible approaches for extracting the journal and issue attributes in #3346 I think it best to close this issue or at the very least remove it from the test column on the project board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants