Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[log] Tracker #17

Closed
3 of 5 tasks
at15 opened this issue Jul 10, 2017 · 2 comments
Closed
3 of 5 tasks

[log] Tracker #17

at15 opened this issue Jul 10, 2017 · 2 comments
Assignees
Milestone

Comments

@at15
Copy link
Member

at15 commented Jul 10, 2017

Not scheduled

  • we can't config third party library that is using the log package
    • this is allowed in Java land, i.e. solr's admin page allow you to config all the package's logging level on the fly)
    • maybe the logger should register itself to a singleton

Working

Finished

@at15 at15 added this to the 0.0.2 milestone Jul 10, 2017
@at15
Copy link
Member Author

at15 commented Aug 7, 2017

we have log entries registered in logger, the problem is, each library use their own logger instance, unless they all use a DefaultLogger or make their logger public, there is no way to control their logging

@at15 at15 self-assigned this Dec 27, 2017
at15 added a commit to dyweb/Ayi that referenced this issue Jan 3, 2018
- mainly after https://github.com/benbjohnson/tmpl use go/format
- used by gommon log dyweb/gommon#17 to
generate different log level
- follow go's generated code standard, add special header
- comment out usage of `go.rice` in `Ayi install`
@at15 at15 modified the milestones: 0.0.2, future Feb 1, 2018
@at15 at15 modified the milestones: future, 0.0.8 Sep 6, 2018
@at15
Copy link
Member Author

at15 commented Dec 9, 2018

fixed in #90

@at15 at15 closed this as completed Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant