Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor performance of SAP RFC V2 #856

Open
2 tasks
marcinpurtak opened this issue Feb 28, 2024 · 0 comments
Open
2 tasks

Poor performance of SAP RFC V2 #856

marcinpurtak opened this issue Feb 28, 2024 · 0 comments
Assignees
Labels
2.0 viadot 2.0 bug Something isn't working

Comments

@marcinpurtak
Copy link
Collaborator

The SAP RFC V2 connector is a legacy code migrated from viadot 1.0.
This code bypases the SAP BBP_READ_TABLE func limitation for length of the columns however there is a lot of for loop in this code which are not memory efficient. Additionaly there is a legacy function to check if additional separators exists in the data which is not used but it slows down the processing.

Steps to finish:

  • Switch from regular for loop to generator approach
  • Remove code responsible for separators check
@marcinpurtak marcinpurtak added bug Something isn't working 2.0 viadot 2.0 labels Feb 28, 2024
@marcinpurtak marcinpurtak self-assigned this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0 viadot 2.0 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant