Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvemenet of pokcetbase plugin statements #124

Open
matteo-cristino opened this issue Apr 11, 2024 · 0 comments
Open

Improvemenet of pokcetbase plugin statements #124

matteo-cristino opened this issue Apr 11, 2024 · 0 comments

Comments

@matteo-cristino
Copy link
Collaborator

Inside pocketbase plugin there are some repetitions that can be avoided:

Given I send create_parameters '' and send record_parameters '' and create record
Given I send update_parameters '' and send record_parameters '' and update record
Given I send delete_parameters '' and delete record

In the above example the action is specified both in the input data and also in the identifier of the statement. Maybe a better solution can be found (possibly by using a single world to indicate a input data in order to have better looking statements).

Finally the following statement

Given I send url '' and send send_parameters '' and send request

use the send token inside the statement identifier that can bring more confusion when writing and mantaining code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant